Skip to content

feat: make init job ttlSecondsAfterFinished configurable and default 1h #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simonhir wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −2
Open

feat: make init job ttlSecondsAfterFinished configurable and default 1h #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aa9779
feat: make init job ttlSecondsAfterFinished configurable
simonhir Dec 16, 2025
aa5c652
conf: init job ttlSecondsAfterFinished default 1h
simonhir Dec 16, 2025
1e6e952
chore: bump chart version 15.7.0
simonhir Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion zammad/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: zammad
version: 15.6.0
version: 15.7.0
appVersion: 6.5.2-46
description: Zammad is a web based open source helpdesk/customer support system with many features to manage customer communication via several channels like telephone, facebook, twitter, chat and e-mails.
home: https://zammad.org
Expand Down
2 changes: 1 addition & 1 deletion zammad/templates/job-init.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
ttlSecondsAfterFinished: 300
ttlSecondsAfterFinished: {{ .Values.zammadConfig.initJob.ttlSecondsAfterFinished }}
template:
metadata:
annotations:
Expand Down
2 changes: 2 additions & 0 deletions zammad/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,6 +499,8 @@ zammadConfig:

initJob:
randomName: true
# specify how long after finish pods are deleted
ttlSecondsAfterFinished: 3600
Copy link
Member

@monotek monotek Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep the current valu as default here.

Suggested change
ttlSecondsAfterFinished: 3600
ttlSecondsAfterFinished: 300

Copy link
Collaborator

@mgruner mgruner Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monotek why? I believe the change was done on purpose to make the default more user friendly. And it should not hurt?

Copy link
Member

@monotek monotek Feb 2, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we change a default value it changes for all users updating the chart unexpectingly.

If we change a default we should raise the major version of the chart an add the change to the upgrading section of the readme.

annotations: {}
# my-annotation: "value"
podLabels: {}
Expand Down
Loading