Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Vendor kerchunk netCDF3 reader (#397)" #408

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Conversation

maxrjones
Copy link
Member

@maxrjones maxrjones commented Jan 30, 2025

This reverts commit 95fce11.

The changes from #397 should no longer be needed after the next release of kerchunk.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.80%. Comparing base (81a76f0) to head (14f216b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
+ Coverage   75.61%   77.80%   +2.18%     
==========================================
  Files          33       31       -2     
  Lines        1993     1820     -173     
==========================================
- Hits         1507     1416      -91     
+ Misses        486      404      -82     
Files with missing lines Coverage Δ
virtualizarr/readers/netcdf3.py 89.47% <100.00%> (+3.75%) ⬆️

@TomNicholas
Copy link
Member

That PR did add a test too, which we should keep.

@maxrjones maxrjones merged commit 92f04de into main Jan 30, 2025
13 checks passed
@maxrjones maxrjones deleted the revert-vendoring branch January 30, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants