Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Vendor kerchunk netCDF3 reader (#397)" #408

Merged
merged 2 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/releases.rst
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ Documentation
Internal Changes
~~~~~~~~~~~~~~~~

- Vendor netCDF3 reader from kerchunk. (:pull:`397`) By `Tom Nicholas <https://github.com/TomNicholas>`_.
- Add netCDF3 test. (:pull:`397`) By `Tom Nicholas <https://github.com/TomNicholas>`_.

.. _v1.2.0:

Expand Down
5 changes: 1 addition & 4 deletions virtualizarr/readers/netcdf3.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def open_virtual_dataset(
virtual_backend_kwargs: Optional[dict] = None,
reader_options: Optional[dict] = None,
) -> Dataset:
from virtualizarr.vendor.kerchunk.netCDF3 import NetCDF3ToZarr
from kerchunk.netCDF3 import NetCDF3ToZarr

if virtual_backend_kwargs:
raise NotImplementedError(
Expand All @@ -38,9 +38,6 @@ def open_virtual_dataset(
loadable_variables,
)

if reader_options is None:
reader_options = {}

refs = NetCDF3ToZarr(filepath, inline_threshold=0, **reader_options).translate()

# both group=None and group='' mean to read root group
Expand Down
21 changes: 0 additions & 21 deletions virtualizarr/vendor/kerchunk/LICENSE.txt

This file was deleted.

Empty file.
307 changes: 0 additions & 307 deletions virtualizarr/vendor/kerchunk/netCDF3.py

This file was deleted.

Loading