v3: use dev version number (draft) #1020
Closed
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For discussion. Until v3 is finalized, using a "dev" marker for the v3 version string would prevent datasets that are written in a transitional state from becoming normative.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 34 34
Lines 13847 13847
=======================================
Hits 13840 13840
Misses 7 7
|
|
Closing this in favor of the environment variable protection, though I think this is a strategy we should consider the next time we are amidst a major overhaul. cc: @jstriebel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For discussion. Until v3 is finalized, using a "dev" marker for the v3 version string would prevent datasets that are written in a transitional state from becoming normative.
This follows on from the PRs by @grlee77 to add support for writing V3 (#898) and to hide those implementations unless the user explicitly sets an environment variable (#1007).
An unknown here is how many v3 filesets are already in the wild. xtensor-zarr (cc: @davidbrochart) and z5 (@constantinpape) have had writing support for some time.
If we decide to move forward with this change, we should synchronize implementations and make an effort to contact (known) users of these transitional v3 implementations.