intc: Shared allocator for Xtensa and RISCV #421
Merged
+70
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raffarost
force-pushed
the
improve/intc_esp32_common_irq
branch
2 times, most recently
from
3764447 to
8e4eb42
Compare
raffarost
force-pushed
the
improve/intc_esp32_common_irq
branch
5 times, most recently
from
b1ac902 to
018990d
Compare
raffarost
commented
Mar 14, 2025
| ARG_UNUSED(n); | ||
|
|
||
| esp_intr_alloc(0, 0, f, arg, NULL); | ||
| esp_intr_alloc(2, 0, f, arg, NULL); |
There was a problem hiding this comment.
since set_intr_wrapper() already routes sources 0 and 2 to IRQ 0, by removing esp_intr_alloc() we avoid allocating two new IRQs, which is unnecessary (see log below set_intr_wrapper() calls):
-------> source 2 routed to IRQ 0
-------> source 0 routed to IRQ 0
sylvioalves
approved these changes
Mar 19, 2025
wmrsouza
approved these changes
Mar 19, 2025
Shared allocator for Xtensa and RISCV Signed-off-by: Raffael Rostagno <[email protected]>
raffarost
force-pushed
the
improve/intc_esp32_common_irq
branch
from
018990d to
41d8a2e
Compare
marekmatej
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shared allocator for Xtensa and RISCV