irq: add nested locking support #425
Open
+346
−461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioalves
requested review from
LucasTambor,
marekmatej,
raffarost and
wmrsouza
as code owners
wmrsouza
approved these changes
Mar 14, 2025
raffarost
reviewed
Mar 14, 2025
raffarost
approved these changes
Mar 14, 2025
LucasTambor
approved these changes
Mar 17, 2025
EricNRS
reviewed
Mar 17, 2025
sylvioalves
force-pushed
the
bugfix/irq_lock_nested
branch
from
6f620e0 to
70016b4
Compare
sylvioalves
force-pushed
the
bugfix/irq_lock_nested
branch
from
70016b4 to
8964f86
Compare
wmrsouza
approved these changes
Mar 19, 2025
raffarost
approved these changes
Mar 19, 2025
LucasTambor
approved these changes
Mar 19, 2025
sylvioalves
force-pushed
the
bugfix/irq_lock_nested
branch
2 times, most recently
from
0a54c98 to
662efb0
Compare
marekmatej
approved these changes
Mar 19, 2025
EricNRS
reviewed
Mar 19, 2025
sylvioalves
force-pushed
the
bugfix/irq_lock_nested
branch
2 times, most recently
from
e39b22c to
7964b34
Compare
sylvioalves
requested review from
marekmatej,
LucasTambor,
wmrsouza and
raffarost
marekmatej
approved these changes
Mar 24, 2025
wmrsouza
approved these changes
Mar 24, 2025
raffarost
approved these changes
Mar 24, 2025
sylvioalves
force-pushed
the
bugfix/irq_lock_nested
branch
2 times, most recently
from
80ce532 to
83e5d0a
Compare
sylvioalves
force-pushed
the
bugfix/irq_lock_nested
branch
from
83e5d0a to
75c6930
Compare
marekmatej
reviewed
Mar 25, 2025
sylvioalves
force-pushed
the
bugfix/irq_lock_nested
branch
from
75c6930 to
e339586
Compare
Make sure Wi-Fi and BLE blob calls have nested and atomic access. The peripherals in this PR need to use atomic and nested call handling as it is either used in RF blobs or spread among multiple drivers. - phy - regi2c - periph_ctrl - esp_timer Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
Make sure all peripherals in this PR use local irq_lock and irq_unlock instead of common nested reference. Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
sylvioalves
force-pushed
the
bugfix/irq_lock_nested
branch
from
e339586 to
0724749
Compare
wmrsouza
approved these changes
Mar 25, 2025
marekmatej
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some RF libraries require that
irq_lockandirq_unlockhave some nested mechanism. This brings such approach to all files linked to RF calls.