tests: Bluetooth: Tester: Fix miss check and alloc in BAP broadcast #100534
+39
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the BAP broadcast functions was missing a check for allocated. Adding the checks exposed a bug in the CAP commands where the broadcasts were never actually allocated. Since there is not a command for that in CAP, a workaround has been implemented to use the first command (setup_stream) to allocate a BAP broadcast with a dummy broadcast ID. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
btp_cap_broadcast_workaround
branch
from
1e3943f to
1f0dc3f
Compare
Contributor
Author
|
#AutoPTS run zephyr CAP/INI/BST |
zephyrbot
added
area: Bluetooth Qualification
zephyrbot
added
area: Tests
|
Scheduled PR #100534 (comment), board: nrf54, estimated start time: 16:18:09, test case count: 12, estimated duration: 0:13:10 Test cases to be runCAP/INI/BST/BV-01-CCAP/INI/BST/BV-02-C CAP/INI/BST/BV-05-C CAP/INI/BST/BV-06-C CAP/INI/BST/BV-07-C CAP/INI/BST/BV-11-C CAP/INI/BST/BV-12-C CAP/INI/BST/BV-13-C CAP/INI/BST/BV-14-C CAP/INI/BST/BV-15-C CAP/INI/BST/BV-16-C CAP/INI/BST/BV-17-C |
zephyrbot
requested review from
alxelax,
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
nashif,
niym-ot and
sjanc
|
|
AutoPTS Bot results: Successful tests (17)CAP CAP/INI/BST/BV-01-C PASSCAP CAP/INI/BST/BV-02-C PASS CAP CAP/INI/BST/BV-03-C PASS CAP CAP/INI/BST/BV-04-C PASS CAP CAP/INI/BST/BV-05-C PASS CAP CAP/INI/BST/BV-06-C PASS (2) CAP CAP/INI/BST/BV-07-C PASS CAP CAP/INI/BST/BV-08-C PASS CAP CAP/INI/BST/BV-09-C PASS CAP CAP/INI/BST/BV-10-C PASS CAP CAP/INI/BST/BV-11-C PASS CAP CAP/INI/BST/BV-12-C PASS CAP CAP/INI/BST/BV-13-C PASS CAP CAP/INI/BST/BV-14-C PASS CAP CAP/INI/BST/BV-15-C PASS CAP CAP/INI/BST/BV-16-C PASS CAP CAP/INI/BST/BV-17-C PASS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the BAP broadcast functions was missing a check for allocated.
Adding the checks exposed a bug in the CAP commands where the broadcasts were never actually allocated. Since there is not a command for that in CAP, a workaround has been implemented to use the first command (setup_stream) to allocate a BAP broadcast with a dummy broadcast ID.