drivers: stepper: refactor enable(dev,flag) to enable & disable #87491
+291
−126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilaypandya
force-pushed
the
fix/stepper-87229
branch
from
f0e2120 to
fa4891c
Compare
jilaypandya
force-pushed
the
fix/stepper-87229
branch
4 times, most recently
from
5621e31 to
683fd66
Compare
zephyrbot
added
area: Samples
zephyrbot
requested review from
bjarki-andreasen,
fabiobaltieri,
faxe1008,
jbehrensnx,
kartben and
nashif
faxe1008
reviewed
Mar 23, 2025
| @@ -708,6 +726,7 @@ static int tmc50xx_stepper_init(const struct device *dev) | |||
| #define TMC50XX_STEPPER_API_DEFINE(child) \ | |||
| static DEVICE_API(stepper, tmc50xx_stepper_api_##child) = { \ | |||
There was a problem hiding this comment.
Just noticed this - why is there an instance of the api per stepper? Shouldn't there only be one?
There was a problem hiding this comment.
This particular driver can support two steppers.
There was a problem hiding this comment.
Yeah but the api is the same for both. If you'd have two bme sensors on your board you end up with only one api instance in your binary - I feel like the same applies here, unlese I miss something
There was a problem hiding this comment.
That's 100% correct, thanks :) Have rectified it :)
jilaypandya
force-pushed
the
fix/stepper-87229
branch
from
683fd66 to
a1eacec
Compare
jilaypandya
force-pushed
the
fix/stepper-87229
branch
from
a1eacec to
245721d
Compare
refactoring enable function into enable and disable increasing readability and increasing coherence with other stepper apis in terms of nomenclature Signed-off-by: Jilay Pandya <[email protected]>
- Add migration guide entry for enable->enable/disable function - Add stepper_disable to stepper.rst Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
fix/stepper-87229
branch
from
245721d to
25f401a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring enable function into enable and disable increasing readability and increasing coherence with other stepper apis in terms of nomenclature
#87229