Add MAX32657 #88651

ozersa · 2025-04-15T11:55:26Z

The MAX32657 microcontroller (MCU) is an advanced system-on-chip (SoC) featuring an Arm® Cortex®-M33 core that has TrustZone support.
This PR add basic MAX32657 support.

There are two board variant
1- Secure board: max32657evkit/max32657
2- Non-Secure board: max32657evkit/max32657/ns

This PR only enable Secure board.

MAX32657 basic features:

1MB Internal Flash
256kB Internal SRAM
Bluetooth 5.4 LE Radio
2 DMA Controllers (Secure and non-Secure)
One SPI Controller/Peripheral
One I2C/I3C
1 Low-Power UART
Six 32-Bit Low Power Timers with PWM
14 Configurable GPIO with Internal Pullup/Pulldown Resistors
Cryptographic Tool Box (CTB) for IP/Data Security

UART Test Output

On next NS board support will be added, PR: #88706

github-actions · 2025-04-15T11:56:56Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_adi	zephyrproject-rtos/hal_adi@`67b8830`	zephyrproject-rtos/hal_adi@`8f33130` (`main`)	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

nordicjm · 2025-04-15T12:26:16Z

west.yml

@@ -142,7 +144,8 @@ manifest:
      groups:
        - fs
    - name: hal_adi
-      revision: 67b88309c327d207e87bb7af6e37c704cd9d5b9d
+      remote: analogdevicesinc


manifest update must come before things that need it

thanks for review, moved as first commit.
Note this commit will be updated with zephyr-rtos/hal_adi link, in next days.

nordicjm · 2025-04-15T12:26:30Z

west.yml

@@ -353,7 +353,7 @@ manifest:
      groups:
        - tee
    - name: trusted-firmware-m
-      revision: 857f3697ece6f44a663f007de71205a7b34974ef
+      revision: pull/128/head


Moved as second commit.

nordicjm · 2025-04-15T12:27:43Z

boards/adi/max32657evkit/doc/index.rst

+Supported Features
+==================
+
+Below interfaces are supported by Zephyr on MAX32657EVKIT.


use hw directive

Replaced thanks.

nordicjm · 2025-04-15T12:28:10Z

boards/adi/max32657evkit/doc/index.rst

+Build the zephyr app for max32657evkit/max32657 board will generate secure firmware
+for zephyr. In this configuration 960KB of flash is used to store the code and 64KB
+is used for storage section. In this mode tf-m is off and secure mode flag is on
+``CONFIG_TRUSTED_EXECUTION_SECURE=y`` and ``CONFIG_BUILD_WITH_TFM=n``


use ```
:kconfig:option<name>

Added kconfig:options, thanks.

nordicjm · 2025-04-15T12:28:23Z

boards/adi/max32657evkit/doc/index.rst

+
+   .. code-block:: bash
+
+      $ west build -b max32657evkit/max32657 samples/basic/blinky/ -p


use west build directive

boards/adi/max32657evkit/max32657evkit_max32657.dts

boards/adi/max32657evkit/max32657evkit_max32657_common.dtsi

nordicjm · 2025-04-15T12:29:28Z

boards/adi/max32657evkit/doc/index.rst

-|           |               | +-----------+ |  +-------------------------------------------------------------------------------+               |
-|           |               | | 1-2       | |  | VDD12 User Selection.                                                         |               |
-|           |               | +-----------+ |  +-------------------------------------------------------------------------------+               |
-|           |               | | 3-4       | |  |  VDD12 AT 1.2 VOLTS.                                                          |               |
-|           |               | +-----------+ |  +-------------------------------------------------------------------------------+               |
-|           |               | | 5-6       | |  | VDD12 AT 1.5 VOLTS.                                                           |               |
-|           |               | +-----------+ |  +-------------------------------------------------------------------------------+               |
-|           |               | | Open      | |  |  VDD12 AT 1.6 VOLTS.                                                          |               |


fix documentation in original commit

Pushed as a separate commit to give credit to committer.

Agree with @nordicjm . Squash into the original commit and add @hfakkiz 's signed-off-by line

boards/adi/max32657evkit/max32657evkit_max32657.yaml

nordicjm · 2025-04-15T12:30:15Z

boards/adi/max32657evkit/Kconfig.defconfig

+# Download MCUBoot version that linked with TF-M
+choice TFM_MCUBOOT_PATH
+	default TFM_MCUBOOT_PATH_DOWNLOAD
+endchoice


Ok removed, but isn't it cause a sync issue? TF-M linked with different point of MCUBoot project. If tf-m uses mcuboot that comes with zephyr it might cause some build or execution issue.

MaureenHelm · 2025-04-23T18:29:41Z

west.yml

-      revision: 67b88309c327d207e87bb7af6e37c704cd9d5b9d
+      revision: pull/21/head


hal_adi PR was merged

Node updated with SHA.

MaureenHelm · 2025-04-23T18:41:07Z

boards/adi/max32657evkit/doc/index.rst

+| storage  | 0x10f0000[64k]   | File system, persistent storage |
+----------+------------------+---------------------------------+
+
+Here are the instructions to build zephyr with a non-secure configuration,


Suggested change

Here are the instructions to build zephyr with a non-secure configuration,

Here are the instructions to build zephyr with a secure configuration,

Applied thanks.

MaureenHelm · 2025-04-23T18:41:57Z

boards/adi/max32657evkit/max32657evkit_max32657.yaml

+toolchain:
+  - zephyr
+  - gnuarmemb
+  - xtools


Remove xtools

MaureenHelm · 2025-04-23T18:43:59Z

boards/adi/max32657evkit/doc/index.rst

-|           |               | +-----------+ |  +-------------------------------------------------------------------------------+               |
-|           |               | | 1-2       | |  | VDD12 User Selection.                                                         |               |
-|           |               | +-----------+ |  +-------------------------------------------------------------------------------+               |
-|           |               | | 3-4       | |  |  VDD12 AT 1.2 VOLTS.                                                          |               |
-|           |               | +-----------+ |  +-------------------------------------------------------------------------------+               |
-|           |               | | 5-6       | |  | VDD12 AT 1.5 VOLTS.                                                           |               |
-|           |               | +-----------+ |  +-------------------------------------------------------------------------------+               |
-|           |               | | Open      | |  |  VDD12 AT 1.6 VOLTS.                                                          |               |


Agree with @nordicjm . Squash into the original commit and add @hfakkiz 's signed-off-by line

Update hal_adi node to get MAX32657 support Signed-off-by: Sadik Ozer <[email protected]>

MAX32657 is Cortex-M33 based Analog Devices MCU. It supports ARM TrustZone security model. There will be two boards of this MCU Secure and Non-Secure This commit defines Secure version of peripherals. Basic feature of MAX32657 device: - Core is Cortex-M33 - 50MHz IPO clock - There are 54 interrupt vectors - 1MB flash & 256 SRAM - MAX32657 has: - 1 x UART - 1 x I2C/I3C - 1 x SPI - 6 x TIMER - 1 x RTC - 1 x WDT - 1 x TRNG Signed-off-by: Sadik Ozer <[email protected]>

ozersa · 2025-04-25T08:46:00Z

@nordicjm please revisit.

boards/adi/max32657evkit/doc/index.rst

This commit add secure board of MAX32657. Only GPIO and UART drivers have been enabled. To build: - west build -b max32657evkit/max32657 -p Co-authored-by:: Furkan Akkiz <[email protected]> Signed-off-by: Sadik Ozer <[email protected]>

Enable JLink runner for MAX32657 Signed-off-by: Sadik Ozer <[email protected]>

Add MAX32657 TRNG device node Add TRNG in MAX32657 board file Signed-off-by: Sadik Ozer <[email protected]>

Add MAX32657 boards overlay files to gpio test be supported. Signed-off-by: Mert Ekren <[email protected]>

github-actions bot added manifest manifest-hal_adi manifest-trusted-firmware-m DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Apr 15, 2025

nordicjm requested changes Apr 15, 2025

View reviewed changes

ozersa force-pushed the add-MAX32657 branch 5 times, most recently from e4ebc73 to c14268d Compare April 16, 2025 10:05

ozersa mentioned this pull request Apr 16, 2025

Add MAX32657 NS Board #88706

Merged

ozersa marked this pull request as ready for review April 16, 2025 10:40

github-actions bot added platform: ADI Analog Devices, Inc. area: GPIO labels Apr 16, 2025

github-actions bot requested review from galak, henrikbrixandersen, MaureenHelm, microbuilder, mnkp, ttmut and yasinustunerg April 16, 2025 10:41

github-actions bot assigned MaureenHelm Apr 16, 2025

ozersa force-pushed the add-MAX32657 branch from c14268d to 6db8053 Compare April 21, 2025 13:07

MaureenHelm requested changes Apr 23, 2025

View reviewed changes

MaureenHelm added this to the v4.2.0 milestone Apr 23, 2025

ozersa added 2 commits April 24, 2025 09:02

manifest: Update hal_adi module for MAX32657

a106e46

Update hal_adi node to get MAX32657 support Signed-off-by: Sadik Ozer <[email protected]>

ozersa force-pushed the add-MAX32657 branch from 6db8053 to 6a4cc2e Compare April 24, 2025 06:25

github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Apr 24, 2025

ozersa force-pushed the add-MAX32657 branch 2 times, most recently from 1c0e866 to 651e566 Compare April 24, 2025 11:20

MaureenHelm previously approved these changes Apr 24, 2025

View reviewed changes

nordicjm self-requested a review April 25, 2025 08:49

nordicjm previously approved these changes Apr 28, 2025

View reviewed changes

kartben requested changes Apr 28, 2025

View reviewed changes

boards/adi/max32657evkit/doc/index.rst Outdated Show resolved Hide resolved

boards/adi/max32657evkit/doc/index.rst Outdated Show resolved Hide resolved

boards/adi/max32657evkit/doc/index.rst Outdated Show resolved Hide resolved

ozersa and others added 4 commits April 28, 2025 10:13

boards: Add MAX32657EVKit board

ad4af11

This commit add secure board of MAX32657. Only GPIO and UART drivers have been enabled. To build: - west build -b max32657evkit/max32657 -p Co-authored-by:: Furkan Akkiz <[email protected]> Signed-off-by: Sadik Ozer <[email protected]>

boards: adi: Enable jlink runner for MAX32657

594ac78

Enable JLink runner for MAX32657 Signed-off-by: Sadik Ozer <[email protected]>

dts: arm: adi: Enable TRNG

4b259ff

Add MAX32657 TRNG device node Add TRNG in MAX32657 board file Signed-off-by: Sadik Ozer <[email protected]>

tests: drivers: gpio: Add MAX32657 boards overlay files

1a93309

Add MAX32657 boards overlay files to gpio test be supported. Signed-off-by: Mert Ekren <[email protected]>

ozersa dismissed stale reviews from nordicjm and MaureenHelm via 1a93309 April 28, 2025 07:19

ozersa force-pushed the add-MAX32657 branch from 651e566 to 1a93309 Compare April 28, 2025 07:19

kartben approved these changes Apr 28, 2025

View reviewed changes

MaureenHelm approved these changes Apr 28, 2025

View reviewed changes

kartben merged commit d557fc5 into zephyrproject-rtos:main Apr 28, 2025
27 checks passed

ozersa deleted the add-MAX32657 branch April 28, 2025 14:48

ozersa mentioned this pull request Apr 29, 2025

Cherry pick adi/max32657 platform support zephyrproject-rtos/trusted-firmware-m#128

Merged


		.. code-block:: bash

		$ west build -b max32657evkit/max32657 samples/basic/blinky/ -p

		revision: 67b88309c327d207e87bb7af6e37c704cd9d5b9d
		revision: pull/21/head

	Here are the instructions to build zephyr with a non-secure configuration,
	Here are the instructions to build zephyr with a secure configuration,

Add MAX32657 #88651

Add MAX32657 #88651

Conversation

ozersa commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ozersa commented Apr 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ozersa commented Apr 15, 2025 •

edited

Loading

github-actions bot commented Apr 15, 2025 •

edited

Loading