Tests: Bluetooth: Tester: Use default number of MBEDTLS PSA Key slots #93117
Conversation
This value defaults to 16, while MESH is using 32. Intention seems to be to cover up to 3 connections but that doesn't mean there should be only 3 key slots available. Signed-off-by: Szymon Janc <[email protected]>
github-actions
bot
added
area: Bluetooth Qualification
github-actions
bot
requested review from
asbjornsabo,
babrsn,
fredrikdanebjer,
jhedberg,
jthm-ot,
larsgk,
niym-ot,
pin-zephyr and
Thalley
|
|
@m-alperen-sener This should also fix MESH regressions |
| @@ -32,7 +32,6 @@ CONFIG_BT_CTLR_ISO_TX_SDU_LEN_MAX=310 | |||
|
|
|||
| # CSIP tests requires up to 3 devices | |||
| CONFIG_BT_MAX_CONN=3 | |||
| CONFIG_MBEDTLS_PSA_KEY_SLOT_COUNT=3 | |||
There was a problem hiding this comment.
As mention on discord, setting this value higher than CONFIG_BT_MAX_PAIRED doesn't really make sense IMO
| @@ -32,7 +32,6 @@ CONFIG_BT_CTLR_ISO_TX_SDU_LEN_MAX=310 | |||
|
|
|||
| # CSIP tests requires up to 3 devices | |||
| CONFIG_BT_MAX_CONN=3 | |||
| CONFIG_MBEDTLS_PSA_KEY_SLOT_COUNT=3 | |||
|
|
|||
| # BAP/BSRC/SCC/BV-38-C requires 2 BIGs | |||
| CONFIG_BT_EXT_ADV_MAX_ADV_SET=2 | |||
There was a problem hiding this comment.
Not a critical one; but depending on the test case this also might break MESH runs; because mesh can use up to 4 ext adv sets. Can we move this to Audio specific overlay?
There was a problem hiding this comment.
We may need to expand on the design here.
The overlay-bt_ll_sw_split.conf was designed to just be used for the multi-CPU boards like nRF53 and nRF54, but that was recently changed in AutoPTS to also be used for the nRF52 (which was never the intention when I added this file, as it is an overlay specifically for the hci_ipc sample.
If we want to run Mesh using the hci_ipc sample and apply an overlay, I think we need to have a common netcore overlay, and then additional ones for audio and mesh. In that case, we need a way to specific if we are building for Mesh or Audio to automatically select the correct overlays
This value defaults to 16, while MESH is using 32. Intention seems to be to cover up to 3 connections but that doesn't mean there should be only 3 key slots available.