Skip to content

Tests: Bluetooth: Tester: Use default number of MBEDTLS PSA Key slots #93117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −1
Open

Tests: Bluetooth: Tester: Use default number of MBEDTLS PSA Key slots #93117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/bluetooth/tester/overlay-bt_ll_sw_split.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ CONFIG_BT_CTLR_ISO_TX_SDU_LEN_MAX=310

# CSIP tests requires up to 3 devices
CONFIG_BT_MAX_CONN=3
CONFIG_MBEDTLS_PSA_KEY_SLOT_COUNT=3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mention on discord, setting this value higher than CONFIG_BT_MAX_PAIRED doesn't really make sense IMO


# BAP/BSRC/SCC/BV-38-C requires 2 BIGs
CONFIG_BT_EXT_ADV_MAX_ADV_SET=2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a critical one; but depending on the test case this also might break MESH runs; because mesh can use up to 4 ext adv sets. Can we move this to Audio specific overlay?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to expand on the design here.

The overlay-bt_ll_sw_split.conf was designed to just be used for the multi-CPU boards like nRF53 and nRF54, but that was recently changed in AutoPTS to also be used for the nRF52 (which was never the intention when I added this file, as it is an overlay specifically for the hci_ipc sample.

If we want to run Mesh using the hci_ipc sample and apply an overlay, I think we need to have a common netcore overlay, and then additional ones for audio and mesh. In that case, we need a way to specific if we are building for Mesh or Audio to automatically select the correct overlays

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is meant to be used only for multicore chips I guess we can revert this in autopts.

However how is this than suppose to be configured for combined builds? Or it shouldn't ? ie LL configuration should be done based on host configs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If by combined builds you mean host and controller on same core, then for combined builds for mesh, using the overlay-mesh.conf, this is set to 32. It's not really a LL configuration per se, but a configuration for wherever the keys are stored I suppose

Applying the overlay-mesh.conf for a combined builds work, but it won't work if you attempt to only apply it for the host/appcore, nor will it work if you attempt to apply it for the controller/netcore on e.g. nRF5340

Expand Down