scripts: build: Fix west build resource leaks #93121
Open
+31
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
fabiobaltieri
previously approved these changes
Jul 14, 2025
pdgendt
reviewed
Jul 14, 2025
decsny
force-pushed
the
fix/west_build_resource_leaks
branch
from
142a44b to
e1bb036
Compare
The files should be closed after done being used, otherwise python warnings are generated from the sys module Signed-off-by: Declan Snyder <[email protected]>
The elf file needs to be closed after done being used, otherwise sys module will generate resource leak warnings. Signed-off-by: Declan Snyder <[email protected]>
decsny
force-pushed
the
fix/west_build_resource_leaks
branch
from
e1bb036 to
aaedbc0
Compare
|
decsny
changed the title
pdgendt
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files were being left open which was generating python sys module warnings about resource leaks when doing west build