shields: devicetree: use arduino-header-r3.h constants in all shields #95320
+374
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
force-pushed
the
shields_arduheader
branch
from
b45b5be to
6027e05
Compare
kartben
force-pushed
the
shields_arduheader
branch
2 times, most recently
from
e079ee8 to
5824a3a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR converts shield device tree overlays to use symbolic GPIO pin constants from arduino-header-r3.h instead of numeric pin values, making the shield configurations less error-prone and easier to maintain.
- Adds include for arduino-header-r3.h header to shield overlay files
- Replaces numeric GPIO pin references with named constants (e.g.,
16becomesARDUINO_HEADER_R3_D10) - Updates multi-line GPIO configurations to use proper line continuation formatting
Reviewed Changes
Copilot reviewed 67 out of 67 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| x_nucleo_wb05kn1_spi.overlay | Updates BLE shield to use symbolic pin constants for CS, reset, and IRQ GPIOs |
| x_nucleo_iks4a1/*.overlay | Updates sensor shield variants to use symbolic pin constants for interrupt GPIOs |
| x_nucleo_iks02a1/*.overlay | Updates sensor shield variants to use symbolic pin constants for data ready GPIOs |
| x_nucleo_iks01a*.overlay | Updates sensor shield variants to use symbolic pin constants for interrupt/data ready GPIOs |
| x_nucleo_idb05a1/*.overlay | Updates BLE shield to use symbolic pin constants for CS, reset, and IRQ GPIOs |
| x_nucleo_eeprma2/*.overlay | Updates EEPROM shield to use symbolic pin constants for write protect and CS GPIOs |
| x_nucleo_bnrg2a1/*.overlay | Updates BLE shield to use symbolic pin constants for CS, reset, and IRQ GPIOs |
| waveshare_epaper/*.overlay | Updates e-paper display shields to use symbolic pin constants for DC, reset, and busy GPIOs |
| wnc_m14a2a/*.overlay | Updates cellular modem shield to use symbolic pin constants for control GPIOs |
| st7789v_generic/*.overlay | Updates display shields to use symbolic pin constants for DC, reset, and CS GPIOs |
| st7735r/*.overlay | Updates display shield to use symbolic pin constants for DC, reset, and CS GPIOs |
| ssd1306/*.overlay | Updates OLED display shield to use symbolic pin constants for data/command GPIO |
| sparkfun_sara_r4/*.overlay | Updates cellular modem shield to use symbolic pin constants for power and reset GPIOs |
| semtech_sx12*/*.overlay | Updates LoRa shields to use symbolic pin constants for reset, DIO, and control GPIOs |
| Additional shields | Similar updates for ethernet, sensor, display, ADC, DAC, and other shield types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kartben
force-pushed
the
shields_arduheader
branch
4 times, most recently
from
9dc2061 to
776f205
Compare
Make shield overlays less error prone and easier to maintain by switching to GPIO pin constants defined in arduino-header-r3.h. Signed-off-by: Benjamin Cabé <[email protected]>
Add mention of ARDUINO_HEADER_R3_* constants in binding description for the Arduino Uno (R3) header. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
force-pushed
the
shields_arduheader
branch
3 times, most recently
from
9579164 to
a63cb86
Compare
zephyrbot
added
area: CAN
area: GPIO
area: Shields
zephyrbot
requested review from
galak,
HoZHel,
jfischer-no,
MaureenHelm,
microbuilder,
ozersa,
ttmut and
yasinustunerg
pdgendt
previously approved these changes
Sep 2, 2025
kartben
changed the title
mniestroj
previously approved these changes
Sep 2, 2025
Add a Doxygen group for the GPIO pin headers macros and initially document Arduino Uno (R3) header pin constants. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
force-pushed
the
shields_arduheader
branch
from
a63cb86 to
a656b21
Compare
mniestroj
approved these changes
Sep 2, 2025
MaureenHelm
approved these changes
Sep 2, 2025
|
jfischer-no
approved these changes
Sep 2, 2025
soburi
approved these changes
Sep 2, 2025
fabiobaltieri
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make shield overlays less error prone and easier to maintain by switching to GPIO pin constants defined in arduino-header-r3.h.
Also start adding Doxygen docs for documenting available constants for common pin headers (see https://builds.zephyrproject.io/zephyr/pr/95320/docs/doxygen/html/group__devicetree-gpio-pin-headers.html)