Problem: Rapid zyre start/stop may create a hello/goodbye storm between peers#753
Merged
sphaero merged 1 commit intozeromq:masterfrom Feb 3, 2026
Merged
Problem: Rapid zyre start/stop may create a hello/goodbye storm between peers#753sphaero merged 1 commit intozeromq:masterfrom
sphaero merged 1 commit intozeromq:masterfrom
Conversation
…en peers Solution: Simply ignore already known peers and let the ping/pong mechanism clean the expired peers on their own, instead of forcing peer removal.
Contributor
|
Good catch. We really need to fix the tests. Diod you look at them. I think the fails are not related? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution: Simply ignore already known peers and let the ping/pong mechanism clean the expired peers on their own, instead of forcing peer removal.