Skip to content

Problem: Rapid zyre start/stop may create a hello/goodbye storm between peers #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sphaero merged 1 commit into from
Feb 3, 2026
Merged

Problem: Rapid zyre start/stop may create a hello/goodbye storm between peers #753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/zyre_node.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1082,10 +1082,18 @@ zyre_node_recv_peer (zyre_node_t *self)
zyre_peer_t *peer = (zyre_peer_t *) zhash_lookup (self->peers, zuuid_str (uuid));
if (zre_msg_id (msg) == ZRE_MSG_HELLO) {
if (peer) {
// Remove fake peers
// ignore already existing peers
if (zyre_peer_ready (peer)) {
zyre_node_remove_peer (self, peer);
assert (!(zyre_peer_t *) zhash_lookup (self->peers, zuuid_str (uuid)));
/*
NB: we ignore peer here instead of destroying due to possible erroneous
destruction in case of rapid deconnection/reconnection of our node, (e.g.,
when wrongly using zyre_start/zyre_stop), in which case the ZRE_MSG_HELLO
may be received twice from other peers and subsequent peers removal would
provoke a HELLO/GOODBYE storm with the erroneously destroyed peers.
In the case of a peer reconnecting with the same endpoint and the previous
one being non-responsive, ping mechanism will take care of cleaning it.
*/
return;
}
else
if (streq (zyre_peer_endpoint (peer), self->endpoint)) {
Expand Down
Loading