-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update .travis.yml #90
Conversation
@zheller any ideas why the tests are failing? |
Neither of us have maintained this project in a while so @sobolevn, your guess is as good as ours -- especially since you seem to know more about what's changed in Python 3.7. Do you mind taking a look? Travis CI failures can be seen by clicking on the link provided by GitHub. Here's the 3.7 failure: https://travis-ci.org/zheller/flake8-quotes/jobs/660032029
|
Sure, I will refactor the tests today 👍 |
Unsure that refactoring is necessary ._. Maybe triage first and report back so you don't waste time with a refactor? |
@twolfson, are you ok with the flake8 requirement change? |
Ah, didn't realize this PR was ready for review. Looking over now |
setup.py
Outdated
@@ -28,7 +28,7 @@ def read(*filenames, **kwargs): | |||
author_email='[email protected]', | |||
version=about['__version__'], | |||
install_requires=[ | |||
'flake8', | |||
'flake8>=3.5', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain this change a little more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason resolved flake8
version was 3.2
It didn't work with 3.8
The first version of flake8
which worked is 3.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, I'd expect the requirements-dev.txt
to supercede this. It looks like in fact, that is what was happening and this change wasn't respected in Travis CI:
(I think you mean [email protected]
, not 3.2
for Python 3.8)
https://travis-ci.org/github/zheller/flake8-quotes/jobs/660092929#L191
The following change where you updated requirements-dev.txt
installs appropriately
https://travis-ci.org/github/zheller/flake8-quotes/jobs/660095678#L191
Can you rollback this line change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I can edit the file in the PR directly so going to do that for speedier turnaround
Co-Authored-By: Todd Wolfson <[email protected]>
Looks like proper version from https://travis-ci.org/github/zheller/flake8-quotes/jobs/666956750#L190 Landing now |
Fwiw, nothing public facing changed so only landing this as a patch revision) |
Released in |
Thanks a lot! 👍 |
Closes #89