Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .travis.yml #90

Merged
merged 6 commits into from
Mar 25, 2020
Merged

Update .travis.yml #90

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8c5f028
Update .travis.yml
sobolevn Mar 9, 2020
09aa767
Update setup.py
sobolevn Mar 9, 2020
750f4a0
Update setup.py
sobolevn Mar 9, 2020
795cbac
Tests pass on 3.8
sobolevn Mar 9, 2020
c86cfad
Update requirements-dev.txt
sobolevn Mar 25, 2020
a725728
Rolled back `flake8` version requirement in `setup.py`
twolfson Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
sudo: false
dist: xenial # is required for python3.7+
language: python
python:
- "2.7"
- "3.4"
- "3.5"
- "3.6"
- "3.7"
- "3.8"

install:
# Install our dependencies
Expand Down
2 changes: 1 addition & 1 deletion requirements-dev.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
flake8<3.4.0,>=3.3.0
flake8>=3.5
4 changes: 3 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def read(*filenames, **kwargs):
author_email='[email protected]',
version=about['__version__'],
install_requires=[
'flake8',
'flake8>=3.5',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this change a little more?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason resolved flake8 version was 3.2
It didn't work with 3.8

The first version of flake8 which worked is 3.5

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I'd expect the requirements-dev.txt to supercede this. It looks like in fact, that is what was happening and this change wasn't respected in Travis CI:

(I think you mean [email protected], not 3.2 for Python 3.8)

750f4a0

https://travis-ci.org/github/zheller/flake8-quotes/jobs/660092929#L191

The following change where you updated requirements-dev.txt installs appropriately

https://travis-ci.org/github/zheller/flake8-quotes/jobs/660095678#L191

795cbac

Can you rollback this line change?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I can edit the file in the PR directly so going to do that for speedier turnaround

],
url='http://github.com/zheller/flake8-quotes/',
long_description=LONG_DESCRIPTION,
Expand Down Expand Up @@ -58,6 +58,8 @@ def read(*filenames, **kwargs):
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Topic :: Software Development :: Libraries :: Python Modules',
'Topic :: Software Development :: Quality Assurance',
]
Expand Down