android: File picker shows all files instead of image gallery UI#2321
android: File picker shows all files instead of image gallery UI#2321Vishnukumardev wants to merge 1 commit into
Conversation
|
@Vishnukumardev Please go thorugh guide on submitting a PR here you can also look for other maintainers PR and commit for reference. Thanks! |
Fixes zulip#1490 where the file picker shows all file types instead of filtering to images only. Changes: - Configured file picker with proper MIME type filter to show image gallery UI - Modified the test for file upload and Added a new test for image upload scenarios Video reference documenting the fix is available in the PR. Fixes: zulip#1490
|
When you tap the gallery button, the intended behavior is to show videos and images for the user to choose from. It looks like this PR would have it show only images, making it impossible for the user to upload videos this way. |
|
I agree @chrisbobbe .Also,there is an ongoing discussion to change the package that handles the media uploading due to unmaintained timeline of the current package used in the app.It is better to keep this issue put.If the package changes as it bear no value. |
|
On second thought,If memory serves me correctly.There hasn't been a dedicated ui for multiple types of file picking option.There is only a button that just loads all the files from the memory .This issue specifically intends to upload image.That is what this PR intends to do.But.if we want to add videos.That is a different scenario I guess.Glad to hear your thoughts moving forward. |
This address the issue #1490 that shows all types of files (PDFs, videos, etc.), not just images.
Discussion :
https://chat.zulip.org/#narrow/channel/48-mobile/topic/Issue.20with.20Gallery.20icon.20behavior
Vide reference given below for the fix
Issue-114.mp4
Fixes : #1490