Skip to content

android: File picker shows all files instead of image gallery UI#2321

Open
Vishnukumardev wants to merge 1 commit into
zulip:mainfrom
Vishnukumardev:main
Open

android: File picker shows all files instead of image gallery UI#2321
Vishnukumardev wants to merge 1 commit into
zulip:mainfrom
Vishnukumardev:main

Conversation

@Vishnukumardev
Copy link
Copy Markdown

@Vishnukumardev Vishnukumardev commented May 15, 2026

This address the issue #1490 that shows all types of files (PDFs, videos, etc.), not just images.
Discussion :
https://chat.zulip.org/#narrow/channel/48-mobile/topic/Issue.20with.20Gallery.20icon.20behavior

Vide reference given below for the fix

Issue-114.mp4

Fixes : #1490

Vishnukumardev

This comment was marked as off-topic.

@Asteriskkkk
Copy link
Copy Markdown

Asteriskkkk commented May 16, 2026

@Vishnukumardev Please go thorugh guide on submitting a PR here you can also look for other maintainers PR and commit for reference. Thanks!

Fixes zulip#1490 where the file picker shows all file types instead of filtering to images only.

Changes:
- Configured file picker with proper MIME type filter to show image
  gallery UI
- Modified the test for file upload and Added a new test for image
  upload scenarios
Video reference documenting the fix is available in the PR.

Fixes: zulip#1490
@Vishnukumardev Vishnukumardev changed the title Fix : File picker shows all files instead of image gallery UI android: File picker shows all files instead of image gallery UI May 17, 2026
@chrisbobbe
Copy link
Copy Markdown
Collaborator

When you tap the gallery button, the intended behavior is to show videos and images for the user to choose from. It looks like this PR would have it show only images, making it impossible for the user to upload videos this way.

@Vishnukumardev
Copy link
Copy Markdown
Author

I agree @chrisbobbe .Also,there is an ongoing discussion to change the package that handles the media uploading due to unmaintained timeline of the current package used in the app.It is better to keep this issue put.If the package changes as it bear no value.

@Vishnukumardev
Copy link
Copy Markdown
Author

On second thought,If memory serves me correctly.There hasn't been a dedicated ui for multiple types of file picking option.There is only a button that just loads all the files from the memory .This issue specifically intends to upload image.That is what this PR intends to do.But.if we want to add videos.That is a different scenario I guess.Glad to hear your thoughts moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File picker shows all files instead of image gallery UI

3 participants