Skip to content

android: File picker shows all files instead of image gallery UI #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vishnukumardev wants to merge 1 commit into
base: main
Choose a base branch
from
+52 −3
Open

android: File picker shows all files instead of image gallery UI #2321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/widgets/compose_box.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,7 @@ class _AttachMediaButton extends _AttachUploadsButton {
@override
Future<Iterable<FileToUpload>> getFiles(BuildContext context) async {
// TODO(#114): This doesn't give quite the right UI on Android.
return _getFilePickerFiles(context, FileType.media);
return _getFilePickerFiles(context, FileType.image);
}
}

Expand Down
53 changes: 51 additions & 2 deletions test/widgets/compose_box_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,6 +1140,55 @@ void main() {
await tester.pump();
}

group('attach file', () {
testWidgets('success', (tester) async {
await prepare(tester);
checkAppearsLoading(tester, false);

testBinding.pickFilesResult = FilePickerResult([PlatformFile(
readStream: Stream.fromIterable(['asdf'.codeUnits]),
path:'/private/var/mobile/Containers/Data/Application/foo/tmp/file.pdf',
name: 'file.pdf',
size: 12345,
),]);
connection.prepare(delay: const Duration(seconds: 1),json:
UploadFileResult(url: '/user_uploads/1/4e/m2A3MSqFnWRLUf9SaPzQ0Up_/file.pdf',).toJson(),
);
await tester.tap(find.byIcon(ZulipIcons.attach_file));
await tester.pump();
final call = testBinding.takePickFilesCalls().single;
check(call.allowMultiple).equals(true);
check(call.type).equals(FileType.any);
checkNoDialog(tester);
check(controller!.content.text,)
.equals('see image: [Uploading file.pdf…]()\n\n');
check(connection.lastRequest!).isA<http.MultipartRequest>()
..method.equals('POST')
..files.single.which(
(it) => it
..field.equals('file')
..length.equals(12345)
..filename.equals('file.pdf')
..contentType.asString.equals(
'application/pdf',
) // ← different MIME type
..has<Future<List<int>>>(
(f) => f.finalize().toBytes(),
'contents',
).completes(
(it) => it.deepEquals(['asdf'.codeUnits].expand((l) => l)),
),
);
checkAppearsLoading(tester, true);

await tester.pump(const Duration(seconds: 1));
check(controller!.content.text).equals(
'see image: [file.pdf](/user_uploads/1/4e/m2A3MSqFnWRLUf9SaPzQ0Up_/file.pdf)\n\n',
);
checkAppearsLoading(tester, false);
});
});

group('attach from media library', () {
testWidgets('success', (tester) async {
await prepare(tester);
Expand All @@ -1160,7 +1209,7 @@ void main() {
await tester.pump();
final call = testBinding.takePickFilesCalls().single;
check(call.allowMultiple).equals(true);
check(call.type).equals(FileType.media);
check(call.type).equals(FileType.image);

checkNoDialog(tester);

Expand Down Expand Up @@ -2544,4 +2593,4 @@ enum _EditInteractionStart {
_EditInteractionStart.restoreFailedEdit => 'from restoring a failed edit',
};
}
}
}