-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safe Interval Path Planner #1184
base: master
Are you sure you want to change the base?
Conversation
docs/modules/5_path_planning/time_based_grid_search/time_based_grid_search_main.rst
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR implements a safe‑interval path planning algorithm for a 2D grid with dynamic obstacles, aimed at reducing redundant node expansions compared to SpaceTime A*.
- Implements a new SafeIntervalPathPlanner class along with supporting Node, NodePath, and interval utilities.
- Adds a dedicated test file to verify the planner’s functionality.
- Updates the GridWithDynamicObstacles module to provide safe interval computation and fixes a loop iteration issue.
Reviewed Changes
File | Description |
---|---|
PathPlanning/TimeBasedPathPlanning/SafeInterval.py | New implementation of the safe‑interval path planning algorithm using SIPP. |
tests/test_safe_interval_path_planner.py | Added unittests verifying the correctness of the safe‑interval planner. |
PathPlanning/TimeBasedPathPlanning/GridWithDynamicObstacles.py | Updates to safe intervals functions and a fix for iterating while modifying a list. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
PathPlanning/TimeBasedPathPlanning/SafeInterval.py:49
- For rich comparisons, lt (and similarly eq) should return NotImplemented instead of raising NotImplementedError. This will ensure proper behavior when comparing against other types.
if not isinstance(other, Node): return NotImplementedError(f"Cannot compare Node with object of type: {type(other)}")
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Wow that copilot review is awesome! |
What does this implement/fix?
Implements the SafeInterval path planning algorithm as described in this paper
Additional information
PR into the gifs repo:
AtsushiSakai/PythonRoboticsGifs#7
Gifs for reference:

250 obstacles:
Hard-coded obstacle pattern:
SpaceTime A* on this same arrangement:
CheckList