OOP refactor #5
Merged
OOP refactor #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement a OOP structure with MetricProvider objects that return prometheus Metrics from the json log result - implement an agnostic NvmeCollector that stores MetricProviders instances and delegates handling the details of Collect and Describe to them - move NvmeCollector instantiation in a convenience function in the main package
…CP metrics inclusion logic: now, if ocp is disabled, we simply don't include the OCP LogMetricCollector in the list. Simplify utils.command.go logic
dobbi84
requested changes
Jul 28, 2025
ftalpo
force-pushed
the
ftalpo/oop_refactor
branch
from
405410f to
e733836
Compare
dobbi84
approved these changes
Jul 29, 2025
LemonySnippet
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dobbi84 prova a vedere come ti sembra ora.
Ho semplificato il codice sotto
utils.command.goper renderlo più simile a prima.Ho implementato una mossa smart che mi era sfuggita: invece che avere un unico
NvmeCollectorinpkg.collector.go, ho diviso i collector in 3 (InfoMetricCollector, unLogMetricCollectorper le metriche non-OCP e unLogMetricCollectorper le metriche OCP), e oranewNvmeCollectorincmd/collector.goistanzia unCompositeCollector, che duranteDescribeeCollectnon fa altro che iterare su tutti iMetricCollectorche si tiene nella sua lista.Così facendo, oltre a rimuovere del codice duplicato come mi avevi fatto notare, quando OCP è enabled aggiungiamo il
LogMetricCollectoranche per le metriche OCP, e quando è disabled lo saltiamo direttamente (questo succede incmd/collector.go), senza bisogno di fareifchecks strani dentroCollecteDescribe.