Skip to content

OOP refactor #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dobbi84 merged 11 commits into from
Jul 29, 2025
Merged

OOP refactor #5

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d8db434
Complete refactor:
ftalpo Jul 18, 2025
e9605d9
Rename method for clarity
ftalpo Jul 21, 2025
cb55d56
Docstring fix
ftalpo Jul 22, 2025
ad6874c
Edit collector creation for clarity
ftalpo Jul 23, 2025
9ec9ca9
Fix CI
ftalpo Jul 23, 2025
e5f056b
Fix PR comments. Implement a CompositeCollector that simplifies the O…
ftalpo Jul 28, 2025
6e04ebc
Fix comments and docstrings
ftalpo Jul 28, 2025
d4670da
Fix: call GetDevices only once per Collect call
ftalpo Jul 28, 2025
8128b61
Change factory func names for clarity
ftalpo Jul 28, 2025
e733836
Docstrings update
ftalpo Jul 28, 2025
fb05f60
Fix PR comments
ftalpo Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ before:

builds:
- id: nvme_exporter
main: ./cmd/nvme_exporter
main: ./cmd
binary: nvme_exporter
ldflags:
- -s -w
Expand Down
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
build:
go build -o ./nvme_exporter ./nvme_exporter
Loading