[No QA] [HelpDot] Add information for admins on freezing/unfreezing an Expensify Card for admins#80724
[No QA] [HelpDot] Add information for admins on freezing/unfreezing an Expensify Card for admins#80724
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://71e993a9.helpdot.pages.dev ⚡️ Updated articles: |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a new section on freezing and unfreezing Expensify Cards to the existing "Set Up and Manage the Expensify Card" article. The content is clearly written and covers a useful workflow, but it has several structural violations against HelpDot governance rules that should be resolved before merging. Scores Summary
Key Findings
Recommendations
Files Reviewed
|
docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/expensify-card/Set-Up-and-Manage-the-Expensify-Card.md
Outdated
Show resolved
Hide resolved
| 3. Tap **Freeze card** or **Unfreeze card**. | ||
| 4. Confirm the action in the popup modal. | ||
|
|
||
| Once frozen: |
There was a problem hiding this comment.
Readability/structure: The "Once frozen:" block is a standalone section of content but lacks a task-based ## heading. Per the authoring guidelines, all content sections below the title must use task-based ## headings. Consider wrapping this in a heading like ## What happens after you freeze an Expensify Card.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@MelvinBot given the review in #80724 (comment), update this PR to comply with our guidelines |
Merge duplicate headings into a single task-based heading and convert the second heading to a plain text intro line. Co-authored-by: Maria D'Costa <[email protected]>
|
Updated the freeze/unfreeze section to address the review feedback:
|
Explanation of Change
Fixed Issues
Part of https://github.com/Expensify/Expensify/issues/593794
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari