Skip to content

Merge main into lucien/fix-qbd-reuse-connection

fc3ee20
Select commit
Loading
Failed to load commit list.
Merged

Reuse existing QBD connection across workspaces #86909

Merge main into lucien/fix-qbd-reuse-connection
fc3ee20
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 8, 2026 in 1s

44.29% (+0.01%) compared to 75e157a

View this Pull Request on Codecov

44.29% (+0.01%) compared to 75e157a

Details

Codecov Report

❌ Patch coverage is 28.88889% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...g/qbd/QuickbooksDesktopExistingConnectionsPage.tsx 0.00% 16 Missing ⚠️
src/pages/workspace/accounting/utils.tsx 0.00% 4 Missing ⚠️
src/libs/actions/connections/index.ts 0.00% 3 Missing ⚠️
src/hooks/useHasPoliciesConnectedToQBD.ts 0.00% 2 Missing ⚠️
...gation/AppNavigator/ModalStackNavigators/index.tsx 0.00% 2 Missing ⚠️
...omponents/ConnectToQuickbooksDesktopFlow/index.tsx 80.00% 1 Missing ⚠️
src/hooks/useAdminPoliciesConnectedToQBD.ts 0.00% 1 Missing ⚠️
...gs/Wallet/ExpensifyCardPage/ChangePINAtATMPage.tsx 0.00% 1 Missing ⚠️
...ages/workspace/accounting/PolicyAccountingPage.tsx 0.00% 1 Missing ⚠️
...pace/accounting/qbd/QuickBooksDesktopSetupPage.tsx 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/ROUTES.ts 16.23% <100.00%> (+0.25%) ⬆️
src/SCREENS.ts 100.00% <ø> (ø)
...gation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 76.92% <ø> (ø)
...s/workspace/accounting/AccountingContext/index.tsx 0.00% <ø> (ø)
...ce/accounting/qbd/RequireQuickBooksDesktopPage.tsx 0.00% <ø> (ø)
src/pages/workspace/accounting/qbd/utils.ts 100.00% <100.00%> (ø)
src/selectors/Policy.ts 64.00% <100.00%> (+1.50%) ⬆️
...omponents/ConnectToQuickbooksDesktopFlow/index.tsx 87.50% <80.00%> (+87.50%) ⬆️
src/hooks/useAdminPoliciesConnectedToQBD.ts 0.00% <0.00%> (ø)
... and 8 more

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.