Develop

[oriNuguri25]

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

• New Features

  • Added a dedicated bank dropdown with placeholder for account setup.
  • Updated new-order notification sound.

• Bug Fixes

  • More reliable population/reset of account information.
  • Improved menu loading flow on the store page for steadier data display.
  • Clearer placeholder handling in dropdowns.

• Style

  • Expanded admin booth sections and editors to full-width layouts.
  • Made sales ranking card more responsive across devices.
  • Applied optional badge color theme on the auth page; switched to a black logo.
  • Refined dropdown appearance (sizes, colors).
  • Minor spacing and width adjustments to fixed bars and tabs.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates asset paths, refactors RedBadge props and styling, adjusts multiple admin layouts to full-width responsiveness, replaces a native select with a custom DropdownSelect for bank selection, modifies DropdownSelect API/behavior, tweaks responsive card widths, updates AdminAuth logo and badge usage, removes a comment, and changes StorePage to a two-step data fetch.

Changes

Cohort / File(s)	Summary
Audio asset path update apps/nowait-admin/src/components/NewOrderToast.tsx	Audio src changed to /assets/sound/newOrder.mp3; no logic changes.
RedBadge API/styling refactor apps/nowait-admin/src/components/RedBadge.tsx	Adds optional props small? and changeColor?; default values; refactors class computation; conditional theming via changeColor.
Admin auth tweaks apps/nowait-admin/src/pages/AdminAuth/AdminAuth.tsx	Switches logo to black; passes changeColor={true} to RedBadge instances; adjusts bottom bar spacing/width.
Analytics card responsiveness apps/nowait-admin/src/pages/AdminAnalytics/components/BoothSalesRankingCard .tsx	Removes default fixed widths; tablet uses full width; non-tablet capped with max-w-[335px]; disabled state forces full width.
Admin booth layout to full width apps/nowait-admin/src/pages/AdminBooth/AdminBooth.tsx, apps/nowait-admin/src/pages/AdminBooth/components/BoothSection.tsx, .../MenuSection.tsx, .../NoticeEditor.tsx, .../OperatingTimeSelector.tsx	Replaces max-w-[614px] with w-full across containers; presentational width changes only.
Account page: bank dropdown & parsing apps/nowait-admin/src/pages/AdminBooth/components/AccountPage.tsx	Adds bank options and uses DropdownSelect for bank; initializes bank as ""; updates parsing and reset logic for account info; layout width tweaks; minor placeholder text change.
DropdownSelect API/behavior apps/nowait-admin/src/pages/AdminBooth/components/DropDown/DropDownSelect.tsx	Adds optional type?: string; robust placeholder detection; dynamic radius (type==="bank" → rounded-xl); text color updates; trigger uses h-full.
Admin home cleanup apps/nowait-admin/src/pages/AdminHome/AdminHome.tsx	Removes one comment; no functional change.
User StorePage two-step fetch apps/nowait-user/src/pages/order/home/StorePage.tsx	Fetches store by numeric ID, then menus by store.publicCode; separates loading states; updates query keys/selectors; adjusts props to children accordingly.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant StorePage
  participant ReservationAPI as Reservation API
  participant MenuAPI as Menu API
  Note over StorePage: Route param storeId (string)
  User->>StorePage: Visit Store Page
  StorePage->>ReservationAPI: getStore(Number(storeId))
  ReservationAPI-->>StorePage: { response: store{ publicCode, ... } }
  alt store.publicCode present
    StorePage->>MenuAPI: getStoreMenus(store.publicCode)
    MenuAPI-->>StorePage: { response: menus{ storeName, menuReadDto } }
    StorePage-->>User: Render header (menus.storeName) and menu list
  else missing publicCode
    Note over StorePage: Menus query disabled
    StorePage-->>User: Render loading/empty state
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Develop #384 — Similar migration to use publicCode for fetching store menus; overlaps with StorePage two-step flow.
• Develop #392 — Edits the same NewOrderToast audio source; direct file overlap.
• develop 변경사항 main으로 병합 #254 — Modifies RedBadge; overlaps with this PR’s RedBadge API/styling changes.

Suggested reviewers

• dgKim1

Poem

I thump my feet—deploy today!
New badges glow, in onyx array.
The booth sprawls wide, no walls to bind,
A dropdown nods, “Choose what you find.”
Two hops for menus—code then fare—
A toast goes ding; I sniff the air.
Ship it swift—carrots to spare! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 492a5e3 and c127785.

⛔ Files ignored due to path filters (2)

• apps/nowait-admin/public/assets/sound/newOrder.mp3 is excluded by !**/*.mp3
• apps/nowait-admin/src/assets/blackLogo.svg is excluded by !**/*.svg

📒 Files selected for processing (13)

• apps/nowait-admin/src/components/NewOrderToast.tsx (1 hunks)
• apps/nowait-admin/src/components/RedBadge.tsx (1 hunks)
• apps/nowait-admin/src/pages/AdminAnalytics/components/BoothSalesRankingCard .tsx (1 hunks)
• apps/nowait-admin/src/pages/AdminAuth/AdminAuth.tsx (6 hunks)
• apps/nowait-admin/src/pages/AdminBooth/AdminBooth.tsx (1 hunks)
• apps/nowait-admin/src/pages/AdminBooth/components/AccountPage.tsx (4 hunks)
• apps/nowait-admin/src/pages/AdminBooth/components/BoothSection.tsx (3 hunks)
• apps/nowait-admin/src/pages/AdminBooth/components/DropDown/DropDownSelect.tsx (3 hunks)
• apps/nowait-admin/src/pages/AdminBooth/components/MenuSection.tsx (1 hunks)
• apps/nowait-admin/src/pages/AdminBooth/components/NoticeEditor.tsx (1 hunks)
• apps/nowait-admin/src/pages/AdminBooth/components/OperatingTimeSelector.tsx (1 hunks)
• apps/nowait-admin/src/pages/AdminHome/AdminHome.tsx (0 hunks)
• apps/nowait-user/src/pages/order/home/StorePage.tsx (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.