Develop #428
Merged
Develop #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: 토스트 알림 로직 --> qa 피드백 적용
fix: 토스트 알림 로직 --> qa 피드백 적용
feat: turbo repo 업데이트
|
Caution Review failedThe pull request is closed. WalkthroughAdds persistent dismissal for new-order toasts, includes order status in toast payloads, changes toast navigation to include order query param, removes in-memory toast cap while limiting rendered toasts to three, and synchronizes AdminOrders detail view and tabs with URL query parameters, including auto-opening details from URL. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Detector as useDetectNewOrders
participant Store as useNewOrderToastStore
participant UI as NewOrderToast
participant Router as Router
participant Admin as AdminOrders
Detector->>Store: pushToast({ id, orderId, status, ... })
Note right of Store: Toast stored (appended).<br/>Dismissed IDs honored downstream.
UI->>UI: Load dismissed IDs from localStorage
UI->>UI: visibles = toasts \\ dismissed (limit 3)
User->>UI: Tap toast
UI->>Router: navigate(/admin/orders/{storeId}?order={orderId})
Router-->>Admin: Render with query (order[, status])
Admin->>Admin: If order in list, open detail<br/>Sync tabs from status
sequenceDiagram
autonumber
participant Router as Router
participant Admin as AdminOrders
participant URL as URLSearchParams
Router-->>Admin: Initial render with ?order, ?status
Admin->>URL: Read order/status
alt order matches existing order
Admin->>Admin: openDetail(order)<br/>- remember scroll<br/>- set selected payment<br/>- navigate replace with order/status
end
Admin->>Admin: Sync tabs from status (desktop/mobile)
Admin-->>Router: On close detail -> remove order (replace)
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
문제점 및 어려움
해결 방안
공유 사항
Summary by CodeRabbit