-
Notifications
You must be signed in to change notification settings - Fork 3
fix: 주점 publicCode로 연결 #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: 주점 publicCode로 연결
|
Caution Review failedThe pull request is closed. WalkthroughRoutes and component handlers were updated to navigate using a store’s publicCode instead of numeric storeId. Types and hooks now include publicCode fields. Bookmark, booth, and home list components propagate publicCode for links. WaitingSummary and StoreDetail adjust identifier sources (navigation by publicCode, mutations by storeId from fetched store). Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant UI as UI Components (Cards/Lists/Modals)
participant Router as Router (/store/{publicCode})
participant StorePage as StoreDetailPage
participant API as API
User->>UI: Click store item
UI->>Router: navigate(`/store/{publicCode}`)
Router->>StorePage: Mount with param publicCode
StorePage->>API: fetch store by publicCode
API-->>StorePage: store { storeId, publicCode, ... }
StorePage->>API: bookmark mutate using store.storeId
note over StorePage,API: Other actions (e.g., reservation) use numeric storeId from fetched store
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (15)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
작업 내용
문제점 및 어려움
해결 방안
공유 사항
Summary by CodeRabbit
New Features
Refactor
Bug Fixes