Skip to content

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Aug 29, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • New Features

    • Store pages now use public codes in URLs. All store links and navigation across Home, Search, Bookmarks, Booth Map, and cards open /store/{publicCode}.
  • Refactor

    • Updated app-wide store references to include public codes across listings and search results.
    • Navigation handlers now pass public codes instead of numeric IDs for store routing.
  • Bug Fixes

    • Bookmark actions on the store detail page now rely on the loaded store data rather than the URL parameter for improved consistency.

@coderabbitai
Copy link

coderabbitai bot commented Aug 29, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Routes and component handlers were updated to navigate using a store’s publicCode instead of numeric storeId. Types and hooks now include publicCode fields. Bookmark, booth, and home list components propagate publicCode for links. WaitingSummary and StoreDetail adjust identifier sources (navigation by publicCode, mutations by storeId from fetched store).

Changes

Cohort / File(s) Summary
Routing updated to use publicCode
apps/nowait-user/src/components/common/modal/SearchModal.tsx, apps/nowait-user/src/pages/home/HomePage.tsx, apps/nowait-user/src/pages/home/components/InfiniteStoreList.tsx, apps/nowait-user/src/pages/home/components/MainCard.tsx, apps/nowait-user/src/pages/home/components/SortWaitingCard.tsx, apps/nowait-user/src/pages/waiting/bookmark/components/BookmarkListItem.tsx, apps/nowait-user/src/pages/waiting/boothMap/components/BoothDetail.tsx, apps/nowait-user/src/pages/waiting/boothMap/components/BoothList.tsx, apps/nowait-user/src/pages/waiting/boothMap/components/BoothListItem.tsx
Navigation paths and handlers now build /store/{publicCode}. Components pass/accept publicCode props to construct links; prior storeId-based links replaced.
Types and hooks extended with publicCode
apps/nowait-user/src/hooks/useInfiniteStores.ts, apps/nowait-user/src/hooks/useWaitingStores.ts, apps/nowait-user/src/types/search.ts, apps/nowait-user/src/types/wait/store.ts
Added publicCode: string to Store/WaitingStore/SearchStore/StoreType interfaces; no control-flow changes.
Waiting and store detail identifier sourcing
apps/nowait-user/src/pages/waiting/WaitingSummary/WaitingSummaryPage.tsx, apps/nowait-user/src/pages/waiting/storeDetail/StoreDetailPage.tsx
WaitingSummary now uses store?.storeId for reservation creation; StoreDetail initializes bookmark hooks after fetching store, using store?.storeId. Routing to detail continues via publicCode.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as UI Components (Cards/Lists/Modals)
  participant Router as Router (/store/{publicCode})
  participant StorePage as StoreDetailPage
  participant API as API

  User->>UI: Click store item
  UI->>Router: navigate(`/store/{publicCode}`)
  Router->>StorePage: Mount with param publicCode
  StorePage->>API: fetch store by publicCode
  API-->>StorePage: store { storeId, publicCode, ... }
  StorePage->>API: bookmark mutate using store.storeId
  note over StorePage,API: Other actions (e.g., reservation) use numeric storeId from fetched store
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Develop #384 — Broad migration from storeId to publicCode across routing and types, overlapping changed areas.
  • Develop #399 — Store page/menu fetching updated to use publicCode, aligning with this routing change.
  • Develop 반영 #316 — Adjusts SearchModal navigation identifier; directly touches the same handler now using publicCode.

Suggested reviewers

  • dgKim1
  • oriNuguri25

Poem

Hop hop, a code-path switch I see,
From numbers to codes, we leap with glee.
Links now sparkle with public flair,
Stores by name, we find them there.
Bookmarks nibble storeId treats,
While routes wear codes on nimble feet. 🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 4ab0ce9 and d8e6650.

📒 Files selected for processing (15)
  • apps/nowait-user/src/components/common/modal/SearchModal.tsx (1 hunks)
  • apps/nowait-user/src/hooks/useInfiniteStores.ts (1 hunks)
  • apps/nowait-user/src/hooks/useWaitingStores.ts (1 hunks)
  • apps/nowait-user/src/pages/home/HomePage.tsx (1 hunks)
  • apps/nowait-user/src/pages/home/components/InfiniteStoreList.tsx (1 hunks)
  • apps/nowait-user/src/pages/home/components/MainCard.tsx (4 hunks)
  • apps/nowait-user/src/pages/home/components/SortWaitingCard.tsx (2 hunks)
  • apps/nowait-user/src/pages/waiting/WaitingSummary/WaitingSummaryPage.tsx (1 hunks)
  • apps/nowait-user/src/pages/waiting/bookmark/components/BookmarkListItem.tsx (4 hunks)
  • apps/nowait-user/src/pages/waiting/boothMap/components/BoothDetail.tsx (2 hunks)
  • apps/nowait-user/src/pages/waiting/boothMap/components/BoothList.tsx (1 hunks)
  • apps/nowait-user/src/pages/waiting/boothMap/components/BoothListItem.tsx (4 hunks)
  • apps/nowait-user/src/pages/waiting/storeDetail/StoreDetailPage.tsx (1 hunks)
  • apps/nowait-user/src/types/search.ts (1 hunks)
  • apps/nowait-user/src/types/wait/store.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hwangdae hwangdae merged commit c8a6fb8 into main Aug 29, 2025
2 of 3 checks passed
@github-actions github-actions bot requested a review from oriNuguri25 August 29, 2025 10:31
This was referenced Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants