Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Windows Viewer Support #604

Closed
wants to merge 4 commits into from

Conversation

ziyanx02
Copy link
Collaborator

Thanks to kohya-ss, the viewer in windows is finally available.

This PR is the same as https://github.com/kohya-ss/Genesis/tree/windows-renderer. README is not updated.

@ziyanx02
Copy link
Collaborator Author

Somehow this commit managed to pass my local format test xd. Wait for someone to help.

@win10ogod
Copy link

win10ogod commented Jan 18, 2025

Can anyone help me?

GenesisException: Camera not yet supported on Windows but is supposed to. Can anyone help?
[Genesis] [17:23:53] [ERROR] Camera not yet supported on Windows but is supposed to. Can anyone help?
[2025-01-18 17:23:53] [ERROR] Camera not yet supported on Windows but is supposed to. Can anyone help?
[Genesis] [17:23:53] [INFO] 💤 Exiting Genesis and caching compiled kernels...
[2025-01-18 17:23:53] [INFO] 💤 Exiting Genesis and caching compiled kernels...

@kohya-ss
Copy link

GenesisException: Camera not yet supported on Windows but is supposed to. Can anyone help?

If you change the following code:

if gs.platform == "Windows":
gs.raise_exception("Camera not yet supported on Windows but is supposed to. Can anyone help?")

as follows, add_camera seems to work as well.

        if gs.platform == "Windows":
            # gs.raise_exception("Camera not yet supported on Windows but is supposed to. Can anyone help?")
            gs.logger.warning("Camera may have some issues on Windows.")

I will change it before submitting the pull request from me.

@kohya-ss
Copy link

@ziyanx02 Thank you for your support. I have submitted a clean pull request for review: #610. Looking forward to your feedback.

@ziyanx02 ziyanx02 closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants