-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make activate set not mess with LOAD_PATH #20
Conversation
Codecov Report
@@ Coverage Diff @@
## release-1.7 #20 +/- ##
===============================================
- Coverage 82.02% 81.17% -0.85%
===============================================
Files 3 3
Lines 89 85 -4
===============================================
- Hits 73 69 -4
Misses 16 16
Continue to review full report at Codecov.
|
Downloaded v1.7.0-beta3.0 just for this... what is this magic?! 😆 julia> using TestEnv
│ Package TestEnv not found, but a package named TestEnv is available from a registry.
│ Install package?
│ (@v1.7) pkg> add TestEnv
└ (y/n) [y]: |
yes, this fixes the issue for me too 😀 |
(btw, this fixes the issue i actually opened, it doesn't get all the way to ReTest.jl working with TestEnv, i'll open a new issue... i think it's a ReTest issue anyway) edit: looks unrelated to TestEnv in fact (JuliaTesting/ReTest.jl#29) |
Make sure it really deactivated Apply suggestions from code review
Should fix #19 .
Does fix it for me.
@nickrobinson251 do you want to take a look and see if it fixes?
This is the branch for julia 1.7, it will need porting to other banches after it is approved
A very nice side bonus of this approach is that
Pkg.activate("originalpath")
actually does indeed remove the test enviroment.