Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make activate set not mess with LOAD_PATH #20

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented Aug 3, 2021

Should fix #19 .
Does fix it for me.

@nickrobinson251 do you want to take a look and see if it fixes?
This is the branch for julia 1.7, it will need porting to other banches after it is approved

A very nice side bonus of this approach is that Pkg.activate("originalpath") actually does indeed remove the test enviroment.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #20 (c6b5d70) into release-1.7 (8d8c90c) will decrease coverage by 0.84%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.7      #20      +/-   ##
===============================================
- Coverage        82.02%   81.17%   -0.85%     
===============================================
  Files                3        3              
  Lines               89       85       -4     
===============================================
- Hits                73       69       -4     
  Misses              16       16              
Impacted Files Coverage Δ
src/activate_set.jl 78.04% <100.00%> (-1.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d8c90c...c6b5d70. Read the comment docs.

@nickrobinson251
Copy link
Contributor

nickrobinson251 commented Aug 3, 2021

nickrobinson251 do you want to take a look and see if it fixes?
This is the branch for julia 1.7, ...

Downloaded v1.7.0-beta3.0 just for this... what is this magic?! 😆

julia> using TestEnv
 │ Package TestEnv not found, but a package named TestEnv is available from a registry.
 │ Install package?
 │   (@v1.7) pkg> add TestEnv
 └ (y/n) [y]:

@nickrobinson251
Copy link
Contributor

yes, this fixes the issue for me too 😀

@nickrobinson251
Copy link
Contributor

nickrobinson251 commented Aug 3, 2021

(btw, this fixes the issue i actually opened, it doesn't get all the way to ReTest.jl working with TestEnv, i'll open a new issue... i think it's a ReTest issue anyway)

edit: looks unrelated to TestEnv in fact (JuliaTesting/ReTest.jl#29)

Make sure it really deactivated

Apply suggestions from code review
@oxinabox oxinabox mentioned this pull request Aug 3, 2021
@oxinabox oxinabox merged commit 8a7924a into release-1.7 Aug 3, 2021
@oxinabox oxinabox deleted the ox/loadpath branch August 3, 2021 20:17
This was referenced Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants