Wifi connector #21
Open
Wifi connector #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now I can connect to my drone but I'm not receiving anything nor are commands arriving. Try the modified |
|
I got wifi to work 🕺 |
|
I kinda forgot what I had left to do :/ |
Mechazawa
commented
Feb 22, 2019
| _setupPeripheral() { | ||
| this.peripheral.discoverAllServicesAndCharacteristics((err, services, characteristics) => { | ||
| if (err) { | ||
| throw err; |
There was a problem hiding this comment.
Can anything even catch this error? 😅
Mechazawa
commented
Oct 3, 2020
Comment on lines
+57
to
+59
| get connected() { | ||
| return this.browser && this.server && this.client; | ||
| } |
There was a problem hiding this comment.
Suggested change
| get connected() { | |
| return this.browser && this.server && this.client; | |
| } | |
| get connected() { | |
| return !this.browser && this.server && this.client; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleaning up the codebase
closes #8