i18n(de): Improve translation#1096
Conversation
See review comments for more information on each string and why it was changed.
randomguy-2650
left a comment
randomguy-2650
left a comment
There was a problem hiding this comment.
Here are the review comments for each change.
| "direction": "ltr", | ||
| "strings": { | ||
| "placeholder": "Suche", | ||
| "placeholder": "Suchen", |
There was a problem hiding this comment.
Infinitive is more natural for a search placeholder than the imperative.
| "clear_search": "Löschen", | ||
| "load_more": "Mehr Ergebnisse laden", | ||
| "search_label": "Suche diese Seite", | ||
| "load_more": "Weitere Ergebnisse laden", |
There was a problem hiding this comment.
Kinda like less vs fewer in English, but “weitere” is more natural and is used for quantities in German.
| "load_more": "Mehr Ergebnisse laden", | ||
| "search_label": "Suche diese Seite", | ||
| "load_more": "Weitere Ergebnisse laden", | ||
| "search_label": "Diese Seite durchsuchen", |
There was a problem hiding this comment.
The previous translation (“Suche diese Seite”) sounds like a command to the user to search the page. This makes it sound more like an action, so like, “This button searches the page”.
| "zero_results": "Keine Ergebnisse für [SEARCH_TERM]", | ||
| "many_results": "[COUNT] Ergebnisse für [SEARCH_TERM]", | ||
| "one_result": "[COUNT] Ergebnis für [SEARCH_TERM]", | ||
| "one_result": "Ein Ergebnis für [SEARCH_TERM]", |
There was a problem hiding this comment.
This avoids using cardinal numbers for the number 1 because some screen readers may otherwise read it as “Eins Ergebnis […]” (or the wrong gender, eine), comparable in English as “One result […]” instead of “A result […]” (not a great example because English has simplified its grammar a lot historically).
This uses the indefinite article to ensure it is read correctly. It also just looks more correct to me (might just be me though).
| "one_result": "Ein Ergebnis für [SEARCH_TERM]", | ||
| "total_zero_results": "Keine Ergebnisse", | ||
| "total_one_result": "[COUNT] Ergebnis", | ||
| "total_one_result": "Ein Ergebnis", |
There was a problem hiding this comment.
See comment on line 13.
| "alt_search": "Keine Ergebnisse für [SEARCH_TERM]. Stattdessen erscheinen Ergebnisse für [DIFFERENT_TERM].", | ||
| "search_suggestion": "Keine Ergebnisse für [SEARCH_TERM]. Probier eine der folgenden Suchen:", | ||
| "searching": "[SEARCH_TERM] wird gesucht …", |
There was a problem hiding this comment.
This removes the bureaucratic passive translation, like writing:
No results for test. Results were instead shown for other test.
Also, the search suggestion has been slightly rewritten from a formal imperative (“Versuchen Sie”, try, as in attempt) to an informal imperative (“Probier”, try, as in taste, but also attempt). Many German websites have been moving away from the formal “Sie” to the informal “du”, not sure what the reason is but it fits well here in my opinion.
Also, the last one is previously kinda ambiguous. It literally translates as “Search for test…”, which sounds weird for a searching state. So I changed it to “test will be searched…” (sounds weird in English but is good in German), with the passive voice.
| "keyboard_navigate": "Navigieren", | ||
| "keyboard_select": "Auswählen", | ||
| "keyboard_clear": "Löschen", | ||
| "keyboard_close": "Schließen", | ||
| "keyboard_search": "Suchen", |
There was a problem hiding this comment.
This capitalises all the imperatives because lowercase looks weird in German. German capitalises nouns and doesn’t like lowercasing the first letter of stuff in cases like this.
| "keyboard_close": "Schließen", | ||
| "keyboard_search": "Suchen", | ||
| "error_search": "Suche fehlgeschlagen", | ||
| "filter_selected_one": "[COUNT] ausgewählt", |
There was a problem hiding this comment.
I didn’t follow what I said in review comment line 13 because it just looks weird to me, I’m not sure if cardinal, nominal (only for number 1) or the indefinite article is appropriate here.
Numbers 1, 11, 101 in cardinal is one, eleven, one hundred one, in nominal, one, one one, one oh/zero one.
| "input_hint": "Ergebnisse erscheinen beim Tippen", | ||
| "loading": "Wird geladen …" |
There was a problem hiding this comment.
For input_hint, the new translation is less bureaucratic.
From something like “Results will be shown during the input” to “Results show while typing”.
The second one just adds the ellipsis to make it look more normal in German.
Co-authored-by: Moritz Weber <kontakt@moritz-weber.net>
2 participants
TL;DR: This PR improves the German translation strings and removes bureaucratic language.
See review comments for more information on each string and why it was changed.