Framework for 1D elevation change calibration#137
Conversation
|
@drounce I'm marking this PR as ready to review. All tests are passing, but there is no test in place as of now to calibrate against 1d elevation change data, which of course is the main addition of this PR. I need to think about if/how we might do this - perhaps a very short chain could be run in a demo notebook, since this calibration method is much slower than our previous calibration options. |
|
Actually, maybe I should just do this before closing this PR. |
|
@drounce this is now ready for review! I added a new notebook (https://github.com/PyGEM-Community/PyGEM-notebooks/blob/dev/advanced_test_spinup_elev_change_calib.ipynb) that tests inversion, spinup, and then calibration against elevation change data for Gulkana, running a very short chain just to demonstrate functionality. All tests passing, which now means that the this new functionality is working as expected. Adding this workflow to the test suite does slow things down a little bit...We're now at ~12 minutes to run all tests. I also updated the sample dataset we have on Drive to include data for Gulkana for the purposes explained here. |
Framework for 1D elevation change calibration (PyGEM-Community#137)
2 participants
No description provided.