Skip to content

[GEN][ZH] Unblock keyboard input on CRC mismatch #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Caball009
Copy link

@Caball009 Caball009 commented Jun 27, 2025

I noticed this issue with a custom map that has a scripted intro readme that stays put for a couple of seconds. Keyboard input is ignored and the mouse cursor is hidden for the duration of the readme. If a replay CRC mismatch is detected during the showing of the readme file, the game is paused and it's annoying to get out of it because user input remains limited.

This PR checks the mouse visibility and if the mouse cursor is hidden on CRC mismatch, the options menu is toggled instead of pausing the game. In progress.

Reproduction steps:

  1. Use map [Mod] Rebel Uprise 2 v10 (This map should be a part of the GenPatcher 'modded' map pack)
  2. Create a replay file, which doesn't have to be longer than 10 - 15 seconds.
    Shouldn't require more than just the local host in a multiplayer match.
  3. Remove the map.ini file from the custom map (or do something else that'll instantly trigger a CRC mismatch).
  4. Play the replay and get an instant CRC mismatch.
  5. The game pauses and blocks keyboard input, and the mouse cursor is hidden.
  6. The easiest way to get out of this is by clicking on the button next to the map to open the menu. Even though the mouse cursor is hidden, the button lights up if you're hovering over it with the mouse.

@Caball009 Caball009 changed the title [GEN][ZH] Open options menu on CRC mismatch if user input is restricted [GEN][ZH] Open options menu on CRC mismatch if user input is limited Jun 27, 2025
@Caball009 Caball009 added Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Jun 27, 2025
@Caball009
Copy link
Author

The new change doesn't make the mouse visible, but I think that's ok. It does unblock keyboard input, so pressing ESC works again. Opening the options menu always makes the mouse visible.

@Caball009 Caball009 changed the title [GEN][ZH] Open options menu on CRC mismatch if user input is limited [GEN][ZH] Unblock keyboard input on CRC mismatch Jun 28, 2025
@xezon xezon added Bug Something is not working right, typically is user facing ThisProject The issue was introduced by this project, or this task is specific to this project labels Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working right, typically is user facing Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker ThisProject The issue was introduced by this project, or this task is specific to this project ZH Relates to Zero Hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants