[GEN][ZH] Do not pause Replay playback on CRC mismatch if a Game Window has input focus #1294
Conversation
xezon
added
Bug
|
Does this mean the game won't pause on mismatch when we are playing back a replay while watching it? |
| Bool pauseInput = FALSE; | ||
| TheGameLogic->setGamePaused(pause, pauseMusic, pauseInput); | ||
| // But not when a window with focus is opened, because that can make resuming difficult. | ||
| if (TheWindowManager->winGetFocus() == NULL) |
There was a problem hiding this comment.
This would mean that the replay never pauses (if there's a window in focus), even though people probably rely on that with a mismatch.
Maybe put the m_crcInfo->setSawCRCMismatch(); at least in this branch? That way the game will pause as soon as the window closes (may be done with scripts).
There was a problem hiding this comment.
Ok. Tested and worked. Will spam mismatch message every 100 frames until pausing.
There was a problem hiding this comment.
That's fine I think as long as it's very unlikely to happen, which seems to be case.
Only if there is a Window that has focus. There typically is none. I tested with the Diplomacy Screen opened and even then the Replay paused. |
xezon
changed the title
This change is an alternative fix to #1209. It prevents the pausing on Replay playback CRC mismatch if there is an active Game Window that has focus and eventually blocks input.