-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Enable validates runner tests for advanced state types for Dataflow. #36808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I believe that this is all supported so removing exclusions and triggering validates runner runs to check. |
|
Run Java PreCommit |
|
Validates runner tests passed on previous run but had to merge trigger file change. |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
1bfc732 to
fbaedc3
Compare
fbaedc3 to
cd93d5e
Compare
|
R: @kennknowles I think the local environment tests are unrelated but I don't know how to retrigger them without running the full verify tests again |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
I don't know how this error crept in, but it doesn't look like something a rerun will fix: (not related to your PR) |
kennknowles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I want to try to see if the tests can be green to discourage broken windows syndrome, but this is a clear-cut case.

V1 runner supports all state types, enabling MapState, SetState, MultimapState, OrderedListState. Batch v1 was failing with enabling multimap so just disabling for now since I just care about streaming.
V2 runner supports OrderedListState
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.