Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(puffin): Add PuffinReader #892

Merged
merged 3 commits into from
Feb 8, 2025
Merged

feat(puffin): Add PuffinReader #892

merged 3 commits into from
Feb 8, 2025

Conversation

fqaiser94
Copy link
Contributor

@fqaiser94 fqaiser94 commented Jan 15, 2025 •
edited
Loading

Part of #744

Summary

  • Add PuffinReader

Context

  • This is the fourth of a number of PRs to add support for Iceberg Puffin file format.
  • It might be helpful to refer to the overarching PR from which these changes were split to understand better how these changes will fit in to the larger picture.
  • It may also be helpful to refer to the Java reference implementation for PuffinReader here.

@fqaiser94 fqaiser94 mentioned this pull request Jan 15, 2025
Open
8 tasks
@fqaiser94 fqaiser94 marked this pull request as ready for review January 15, 2025 12:28
@kevinjqliu kevinjqliu mentioned this pull request Jan 17, 2025
Merged
liurenjie1024
liurenjie1024 reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fqaiser94 for this great pr, generally LGTM! Just some minor suggestions.

@fqaiser94 fqaiser94 force-pushed the puffin_reader branch 2 times, most recently from 4d64762 to 2216a8b Compare January 23, 2025 01:54
@fqaiser94 fqaiser94 force-pushed the puffin_reader branch 4 times, most recently from 8b2af10 to e15baab Compare January 25, 2025 13:11
Xuanwo
Xuanwo approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @fqaiser94 for working on this!

@Xuanwo Xuanwo merged commit a22440e into apache:main Feb 8, 2025
18 checks passed
@fqaiser94 fqaiser94 deleted the puffin_reader branch February 8, 2025 18:10
@fqaiser94 fqaiser94 mentioned this pull request Apr 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liurenjie1024 liurenjie1024 liurenjie1024 left review comments

@waynexia waynexia waynexia left review comments

@Fokko Fokko Fokko approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fqaiser94 @Fokko @liurenjie1024 @Xuanwo @waynexia