Skip to content

Edit comments sRGB for HDR usage #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Edit comments sRGB for HDR usage #20281

wants to merge 1 commit into from
+11 −11

Conversation

studnikoff
Copy link

@studnikoff studnikoff commented Jul 25, 2025 •
edited
Loading

Objective

Fixing comments for sRGBA values to reflect HDR impact #20280

Solution

Add comments to bevy_color

@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@studnikoff studnikoff mentioned this pull request Jul 25, 2025
Open
@JMS55
Copy link
Contributor

JMS55 commented Jul 25, 2025

Depends on the context. E.g. StandardMaterial::base_color shouldn't ever be >1.0.

@studnikoff
Copy link
Author

Depends on the context. E.g. StandardMaterial::base_color shouldn't ever be >1.0.

thanks, I'll dive into pbr to understand how hdr work with StandardMaterial

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jul 27, 2025
@alice-i-cecile alice-i-cecile added the D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes label Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viridia viridia viridia approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@studnikoff @JMS55 @viridia @alice-i-cecile