Skip to content

Edit comments sRGB for HDR usage #20281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −11
Open

Edit comments sRGB for HDR usage #20281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions crates/bevy_color/src/srgba.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,13 @@ use thiserror::Error;
reflect(Serialize, Deserialize)
)]
pub struct Srgba {
/// The red channel. [0.0, 1.0]
/// The red channel. [0.0, 1.0], but larger values are allowed for HDR.
pub red: f32,
/// The green channel. [0.0, 1.0]
/// The green channel. [0.0, 1.0], but larger values are allowed for HDR.
pub green: f32,
/// The blue channel. [0.0, 1.0]
/// The blue channel. [0.0, 1.0], but larger values are allowed for HDR.
pub blue: f32,
/// The alpha channel. [0.0, 1.0]
/// The alpha channel. [0.0, 1.0], but larger values are allowed for HDR.
pub alpha: f32,
}

Expand Down Expand Up @@ -80,10 +80,10 @@ impl Srgba {
///
/// # Arguments
///
/// * `red` - Red channel. [0.0, 1.0]
/// * `green` - Green channel. [0.0, 1.0]
/// * `blue` - Blue channel. [0.0, 1.0]
/// * `alpha` - Alpha channel. [0.0, 1.0]
/// * `red` - Red channel. [0.0, 1.0], but larger values are allowed for HDR.
/// * `green` - Green channel. [0.0, 1.0], but larger values are allowed for HDR.
/// * `blue` - Blue channel. [0.0, 1.0], but larger values are allowed for HDR.
/// * `alpha` - Alpha channel. [0.0, 1.0], but larger values are allowed for HDR.
pub const fn new(red: f32, green: f32, blue: f32, alpha: f32) -> Self {
Self {
red,
Expand All @@ -97,9 +97,9 @@ impl Srgba {
///
/// # Arguments
///
/// * `red` - Red channel. [0.0, 1.0]
/// * `green` - Green channel. [0.0, 1.0]
/// * `blue` - Blue channel. [0.0, 1.0]
/// * `red` - Red channel. [0.0, 1.0], but larger values are allowed for HDR.
/// * `green` - Green channel. [0.0, 1.0], but larger values are allowed for HDR.
/// * `blue` - Blue channel. [0.0, 1.0], but larger values are allowed for HDR.
pub const fn rgb(red: f32, green: f32, blue: f32) -> Self {
Self {
red,
Expand Down
Loading