🐛 Fixes BSN suport for fully qualified component paths#24817
Open
ekwoka wants to merge 1 commit into
Open
Conversation
kfc35
added
A-Scenes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Currently using fully qualified paths in
bsn!fails compilationThis is due to the parser seeing the
:token and immediately going to the scene parsing path.Solution
Check that the token isn't part of
::when checking for that branch.Testing
There didn't seem to be any testing of the actual macro parsing (that I could find) so I put a simple test that just makes sure it compiled and produces a valid scene, though doesn't check that the scene is ACTUALLY "correct".