Feat Cross App CallActivity #1468

cicoyle · 2025-07-25T17:06:47Z

Add support for cross app call activity calls.

sdk-workflows/pom.xml

sdk-autogen/pom.xml

cicoyle · 2025-07-25T17:20:53Z

Note, this PR should be cherrypicked into the release branch once merged.

cicoyle · 2025-07-25T17:25:42Z

This PR is also dependent on the dapr release for 1.16. Javi has a PR to update to the latest rc version here. We will need both merged in, then cherrypick both to the release branch

examples/src/main/java/io/dapr/examples/workflows/README.md

cicoyle · 2025-08-07T20:22:36Z

I need to release durabletask-java with this PR merged in before this current PR will be green

salaboy · 2025-08-11T13:21:34Z

@cicoyle I was looking at this PR, but it doesn't have anything related to cross app call activity.

cicoyle · 2025-08-11T13:35:50Z

@cicoyle I was looking at this PR, but it doesn't have anything related to cross app call activity.

Did you by chance read the thorough readme updates I added?

cicoyle · 2025-08-12T01:11:51Z

I just got a workflow IT test locally 🎉 Need to cleanup and push, will do that + fix the conflict in my morning. Please feel free to review everything else and know I will update the pom.xml in my morning and add an IT test. Ill remove the mechanical markdown since Ill be adding the IT test.

.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java

salaboy

@cicoyle I've left a bunch of comments and suggestions. I am really against adding support for customHttp and customGrpc ports that is something that users shouldn't need to do as that goes against the idea of using containers that are started with random ports, but still allow the user to obtain the mapped ports to connect to them.

examples/src/main/java/io/dapr/examples/workflows/README.md

.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java

testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java

salaboy

@cicoyle overall the example looks good and the new additions for Cross App Call are good, but I believe that all the changes in the DaprContainer class will cause issues. I am curious to see what are the issues that you are facing if you don't introduce any change in that class.

DaprContainer is a critical class being used by customers now, so I would change the behavior of it.

My recommendation would be to revert the changes on DaprContainer and I can help you to figure out what is going wrong with the containers when the pipelines fail.

salaboy · 2025-08-26T07:46:37Z

@cicoyle codecov is still failing and sb 3.3.x was cancelled for some reason, I think the changes in the PR are ok if the pipelines and codecov are green.

cicoyle · 2025-08-26T14:48:45Z

@cicoyle codecov is still failing and sb 3.3.x was cancelled for some reason, I think the changes in the PR are ok if the pipelines and codecov are green.

I pushed a test that should appease codecov. I also upped the test timeout to unblock this PR. I will open an issue to parallelize the test suite a bit bc it should not take this long.

cicoyle · 2025-08-26T14:56:09Z

created this issue

examples/src/main/java/io/dapr/examples/workflows/README.md

artur-ciocanu

@cicoyle this looks great! I have left some comments. Some of them are nitpicks.

I want to make sure that all the ITs that are using Testcontainers follow the same pattern and we rely on Testcontainer machinery for all the resource bootstrap and cleanup.

I am guessing you have run into issues that's why you added the ensureDependenciesCopied() method, but my question is why can't we have everything done during build, so we don't have to invoke Maven during IT execution.

.github/workflows/build.yml

examples/src/main/java/io/dapr/examples/workflows/crossapp/CrossAppWorkflow.java

examples/src/main/java/io/dapr/examples/workflows/README.md

examples/src/main/java/io/dapr/examples/workflows/crossapp/App2TransformActivity.java

sdk-tests/src/test/java/io/dapr/it/testcontainers/workflows/crossapp/CrossAppWorkflow.java

.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java

Signed-off-by: Cassandra Coyle <[email protected]>

Signed-off-by: Javier Aliaga <[email protected]>

javier-aliaga · 2025-09-02T11:38:56Z

@artur-ciocanu @salaboy I fixed all you comments and suggestion, can you take look again?

salaboy

LGTM, thanks @javier-aliaga for adding the @containers to the test.. that will simplify our lives

.github/workflows/build.yml

.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java

sdk-workflows/pom.xml

codecov · 2025-09-02T11:49:10Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.89%. Comparing base (d759c53) to head (13921bf).
⚠️ Report is 215 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1468      +/-   ##
============================================
+ Coverage     76.91%   78.89%   +1.98%     
- Complexity     1592     1934     +342     
============================================
  Files           145      237      +92     
  Lines          4843     5952    +1109     
  Branches        562      611      +49     
============================================
+ Hits           3725     4696     +971     
- Misses          821      936     +115     
- Partials        297      320      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

* cross app ex Signed-off-by: Cassandra Coyle <[email protected]> * update protoc cmd Signed-off-by: Cassandra Coyle <[email protected]> * feedback Signed-off-by: Cassandra Coyle <[email protected]> * builder pattern Signed-off-by: Cassandra Coyle <[email protected]> * fix protoc Signed-off-by: Cassandra Coyle <[email protected]> * debug log levels for test containers Signed-off-by: Cassandra Coyle <[email protected]> * update readme and add debugging info Signed-off-by: Cassandra Coyle <[email protected]> * add IT test for cross app call activity Signed-off-by: Cassandra Coyle <[email protected]> * cleanup test Signed-off-by: Cassandra Coyle <[email protected]> * sysout -> ctx.logger Signed-off-by: Cassandra Coyle <[email protected]> * reset pom Signed-off-by: Cassandra Coyle <[email protected]> * rm debug lines from readme Signed-off-by: Cassandra Coyle <[email protected]> * fix header + rm customports Signed-off-by: Cassandra Coyle <[email protected]> * use consts Signed-off-by: Cassandra Coyle <[email protected]> * rm waitfor call Signed-off-by: Cassandra Coyle <[email protected]> * rm pubsub Signed-off-by: Cassandra Coyle <[email protected]> * rm timeout Signed-off-by: Cassandra Coyle <[email protected]> * reset empty lines added Signed-off-by: Cassandra Coyle <[email protected]> * reset appname for daprcontainer Signed-off-by: Cassandra Coyle <[email protected]> * reset empty line diff Signed-off-by: Cassandra Coyle <[email protected]> * rm constructor info from readme Signed-off-by: Cassandra Coyle <[email protected]> * debug -> info Signed-off-by: Cassandra Coyle <[email protected]> * rm super.start Signed-off-by: Cassandra Coyle <[email protected]> * reset dapr container diff Signed-off-by: Cassandra Coyle <[email protected]> * add test for codecov Signed-off-by: Cassandra Coyle <[email protected]> * up timeout time to unblock PR Signed-off-by: Cassandra Coyle <[email protected]> * deps: Update durabletask-client to 1.5.10 Signed-off-by: Javier Aliaga <[email protected]> * ci: Revert build timeout Signed-off-by: Javier Aliaga <[email protected]> * review: Use ctx.getLogger Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix review comments Signed-off-by: Javier Aliaga <[email protected]> * chore: more review comments fixes Signed-off-by: Javier Aliaga <[email protected]> * test: Use testcontainers in CrossApp IT test Signed-off-by: Javier Aliaga <[email protected]> * chore: Load classpath for IT with all dependencies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Javier Aliaga <[email protected]>

* cross app ex Signed-off-by: Cassandra Coyle <[email protected]> * update protoc cmd Signed-off-by: Cassandra Coyle <[email protected]> * feedback Signed-off-by: Cassandra Coyle <[email protected]> * builder pattern Signed-off-by: Cassandra Coyle <[email protected]> * fix protoc Signed-off-by: Cassandra Coyle <[email protected]> * debug log levels for test containers Signed-off-by: Cassandra Coyle <[email protected]> * update readme and add debugging info Signed-off-by: Cassandra Coyle <[email protected]> * add IT test for cross app call activity Signed-off-by: Cassandra Coyle <[email protected]> * cleanup test Signed-off-by: Cassandra Coyle <[email protected]> * sysout -> ctx.logger Signed-off-by: Cassandra Coyle <[email protected]> * reset pom Signed-off-by: Cassandra Coyle <[email protected]> * rm debug lines from readme Signed-off-by: Cassandra Coyle <[email protected]> * fix header + rm customports Signed-off-by: Cassandra Coyle <[email protected]> * use consts Signed-off-by: Cassandra Coyle <[email protected]> * rm waitfor call Signed-off-by: Cassandra Coyle <[email protected]> * rm pubsub Signed-off-by: Cassandra Coyle <[email protected]> * rm timeout Signed-off-by: Cassandra Coyle <[email protected]> * reset empty lines added Signed-off-by: Cassandra Coyle <[email protected]> * reset appname for daprcontainer Signed-off-by: Cassandra Coyle <[email protected]> * reset empty line diff Signed-off-by: Cassandra Coyle <[email protected]> * rm constructor info from readme Signed-off-by: Cassandra Coyle <[email protected]> * debug -> info Signed-off-by: Cassandra Coyle <[email protected]> * rm super.start Signed-off-by: Cassandra Coyle <[email protected]> * reset dapr container diff Signed-off-by: Cassandra Coyle <[email protected]> * add test for codecov Signed-off-by: Cassandra Coyle <[email protected]> * up timeout time to unblock PR Signed-off-by: Cassandra Coyle <[email protected]> * deps: Update durabletask-client to 1.5.10 Signed-off-by: Javier Aliaga <[email protected]> * ci: Revert build timeout Signed-off-by: Javier Aliaga <[email protected]> * review: Use ctx.getLogger Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix review comments Signed-off-by: Javier Aliaga <[email protected]> * chore: more review comments fixes Signed-off-by: Javier Aliaga <[email protected]> * test: Use testcontainers in CrossApp IT test Signed-off-by: Javier Aliaga <[email protected]> * chore: Load classpath for IT with all dependencies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Javier Aliaga <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>

cicoyle requested review from a team as code owners July 25, 2025 17:06

cicoyle commented Jul 25, 2025

View reviewed changes

sdk-workflows/pom.xml Outdated Show resolved Hide resolved

cicoyle commented Jul 25, 2025

View reviewed changes

sdk-autogen/pom.xml Outdated Show resolved Hide resolved

salaboy reviewed Jul 25, 2025

View reviewed changes

examples/src/main/java/io/dapr/examples/workflows/README.md Outdated Show resolved Hide resolved

cicoyle commented Aug 12, 2025

View reviewed changes

.../test/java/io/dapr/it/testcontainers/workflows/crossapp/WorkflowsCrossAppCallActivityIT.java Outdated Show resolved Hide resolved

salaboy requested changes Aug 13, 2025

View reviewed changes

cicoyle added this to the v1.16 milestone Aug 19, 2025

cicoyle requested a review from salaboy August 21, 2025 21:45

salaboy reviewed Aug 22, 2025

View reviewed changes

testcontainers-dapr/src/main/java/io/dapr/testcontainers/DaprContainer.java Outdated Show resolved Hide resolved

salaboy requested changes Aug 22, 2025

View reviewed changes

cicoyle requested a review from salaboy August 26, 2025 14:48

mikeee modified the milestones: v1.16, maintainer action required Aug 26, 2025

kendallroden reviewed Aug 28, 2025

View reviewed changes

examples/src/main/java/io/dapr/examples/workflows/README.md Show resolved Hide resolved

artur-ciocanu reviewed Aug 30, 2025

View reviewed changes

javier-aliaga force-pushed the feat-cross-app-wf branch 2 times, most recently from 61918a6 to 714b787 Compare September 2, 2025 06:43

cicoyle added 3 commits September 2, 2025 09:41

cross app ex

8f453d6

Signed-off-by: Cassandra Coyle <[email protected]>

update protoc cmd

455467c

Signed-off-by: Cassandra Coyle <[email protected]>

feedback

869cb83

Signed-off-by: Cassandra Coyle <[email protected]>

cicoyle and others added 19 commits September 2, 2025 09:41

fix header + rm customports

b5f541b

Signed-off-by: Cassandra Coyle <[email protected]>

use consts

710ba9d

Signed-off-by: Cassandra Coyle <[email protected]>

rm waitfor call

0d5c425

Signed-off-by: Cassandra Coyle <[email protected]>

rm pubsub

b0e5e23

Signed-off-by: Cassandra Coyle <[email protected]>

rm timeout

015d200

Signed-off-by: Cassandra Coyle <[email protected]>

reset empty lines added

46f6c3b

Signed-off-by: Cassandra Coyle <[email protected]>

reset appname for daprcontainer

a45cb00

Signed-off-by: Cassandra Coyle <[email protected]>

reset empty line diff

14c9185

Signed-off-by: Cassandra Coyle <[email protected]>

rm constructor info from readme

6f42fed

Signed-off-by: Cassandra Coyle <[email protected]>

debug -> info

5dd363d

Signed-off-by: Cassandra Coyle <[email protected]>

rm super.start

3613cd3

Signed-off-by: Cassandra Coyle <[email protected]>

reset dapr container diff

1aaefa6

Signed-off-by: Cassandra Coyle <[email protected]>

add test for codecov

4e9fab4

Signed-off-by: Cassandra Coyle <[email protected]>

up timeout time to unblock PR

c1aadc1

Signed-off-by: Cassandra Coyle <[email protected]>

deps: Update durabletask-client to 1.5.10

973ed3c

Signed-off-by: Javier Aliaga <[email protected]>

ci: Revert build timeout

a5ecd04

Signed-off-by: Javier Aliaga <[email protected]>

review: Use ctx.getLogger

ed8214d

Signed-off-by: Javier Aliaga <[email protected]>

chore: Fix review comments

b756cde

Signed-off-by: Javier Aliaga <[email protected]>

chore: more review comments fixes

efa979c

Signed-off-by: Javier Aliaga <[email protected]>

javier-aliaga force-pushed the feat-cross-app-wf branch from b962ce7 to efa979c Compare September 2, 2025 07:41

javier-aliaga added 2 commits September 2, 2025 11:35

test: Use testcontainers in CrossApp IT test

101904d

Signed-off-by: Javier Aliaga <[email protected]>

chore: Load classpath for IT with all dependencies

13921bf

Signed-off-by: Javier Aliaga <[email protected]>

salaboy approved these changes Sep 2, 2025

View reviewed changes

salaboy merged commit 9fc16c2 into dapr:master Sep 2, 2025
10 checks passed

Feat Cross App CallActivity #1468

Feat Cross App CallActivity #1468

Uh oh!

Conversation

cicoyle commented Jul 25, 2025

Uh oh!

Uh oh!

Uh oh!

cicoyle commented Jul 25, 2025

Uh oh!

cicoyle commented Jul 25, 2025

Uh oh!

Uh oh!

cicoyle commented Aug 7, 2025

Uh oh!

salaboy commented Aug 11, 2025

Uh oh!

cicoyle commented Aug 11, 2025

Uh oh!

cicoyle commented Aug 12, 2025

Uh oh!

Uh oh!

salaboy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

salaboy left a comment

Choose a reason for hiding this comment

Uh oh!

salaboy commented Aug 26, 2025

Uh oh!

cicoyle commented Aug 26, 2025

Uh oh!

cicoyle commented Aug 26, 2025

Uh oh!

Uh oh!

artur-ciocanu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javier-aliaga commented Sep 2, 2025

Uh oh!

salaboy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 2, 2025

Codecov Report

Uh oh!

Uh oh!

salaboy left a comment •

edited

Loading