ci: fix incorrect field key in the goreleaser and rc label #10254
+27
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
not intended for user to use. Repo viewer will not be able to see it when it is labeled as `draft`. Taking one step back , why do we publish rc with helm chart as an asset? There is a Github action called `publish helm chart` publishes it to the helm repo at helm.determined.ai. So ArgoCD can find it and upgrade the release party cluster. For more context, check out: #10141
maxrussell
approved these changes
Mar 14, 2025
jgongd
changed the title
jgongd
added a commit
that referenced
this pull request
Mar 14, 2025
Fix a incorrect field key in the goreleaser config files. Label release candidate as draft instead of pre-release. RC is not intended for user to use. Repo viewer will not be able to see it when it is labeled as `draft`. Taking one step back, why do we publish rc with helm chart as an asset? There is a Github action called `publish helm chart` publishes it to the helm repo at helm.determined.ai. So ArgoCD can find it and upgrade the release party cluster. For more context, check out: #10141
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
publish-helm-gh-rc.draft. Taking one step back , why do we publish rc with helm chart as an asset? There is a Github action calledpublish helm chartpublishes it to the helm repo at helm.determined.ai. So ArgoCD can find it and upgrade the release party cluster. For more context, check out: build: INFENG-937: Publish Helm chart release candidates #10141Test Plan
publish-helm-gh-rcto verify the fix.goreleaser check -f .goreleaser_rc.ymlto check if the configuration is valid. Observe release candidates > 0.38.1-rc3 are not visible to repo viewer.Checklist
docs/release-notes/See Release Note for details.