Skip to content

ci: fix incorrect field key in the goreleaser and rc label #10254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgongd merged 2 commits into from
Mar 14, 2025
Merged

ci: fix incorrect field key in the goreleaser and rc label #10254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bbafb7
ci: fix incorrect field key in the goreleaser
jgongd Mar 13, 2025
b53b3ca
Label release candidate as `draft` instead of `pre-release`. RC is
jgongd Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions helm/.goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ release:
mode: keep-existing
extra_files:
- glob: build/determined-latest.tgz
name_template: "determined-helm-chart_{{ .VERSION }}.tgz"
prerelease: auto
name_template: "determined-helm-chart_{{ .Version }}.tgz"

# be sure to keep this in sync between agent/master/helm
# the "include" functionality is only in the pro version
Expand Down
2 changes: 1 addition & 1 deletion helm/.goreleaser_dryrun.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ release:
mode: keep-existing
extra_files:
- glob: build/determined-latest.tgz
name_template: "determined-helm-chart_{{ .VERSION }}.tgz"
name_template: "determined-helm-chart_{{ .Version }}.tgz"

# be sure to keep this in sync between agent/master/helm
# the "include" functionality is only in the pro version
Expand Down
2 changes: 1 addition & 1 deletion helm/.goreleaser_ee.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ release:
mode: keep-existing
extra_files:
- glob: build/determined-latest.tgz
name_template: "hpe-mlde-helm-chart_{{ .VERSION }}.tgz"
name_template: "hpe-mlde-helm-chart_{{ .Version }}.tgz"

# be sure to keep this in sync between agent/master/helm
# the "include" functionality is only in the pro version
Expand Down
2 changes: 1 addition & 1 deletion helm/.goreleaser_ee_dryrun.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ release:
mode: keep-existing
extra_files:
- glob: build/determined-latest.tgz
name_template: "hpe-mlde-helm-chart_{{ .VERSION }}.tgz"
name_template: "hpe-mlde-helm-chart_{{ .Version }}.tgz"

# be sure to keep this in sync between agent/master/helm
# the "include" functionality is only in the pro version
Expand Down
22 changes: 22 additions & 0 deletions helm/.goreleaser_rc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Beside draft: true, the rest of the file remains the same as .goreleaser.yml.
# Can be avoided by upgrading goreleaser to 1.26.0. Its CLI supports --draft.
project_name: determined-helm

build:
skip: true

release:
github:
owner: determined-ai
name: determined
mode: keep-existing
extra_files:
- glob: build/determined-latest.tgz
name_template: "determined-helm-chart_{{ .Version }}.tgz"
draft: true

# be sure to keep this in sync between agent/master/helm
# the "include" functionality is only in the pro version
header: |
## Release Notes
[{{ .Tag }}](https://github.com/determined-ai/determined/blob/{{ .Tag }}/docs/release-notes.rst)
2 changes: 1 addition & 1 deletion helm/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ release-gh-rc: export GORELEASER_PREVIOUS_TAG := $(shell git tag --sort=-creator
release-gh-rc:
go install github.com/goreleaser/[email protected]
git clean -df
goreleaser --rm-dist
goreleaser --rm-dist -f ./.goreleaser_rc.yml

.PHONY: release-gh-dryrun
release-gh-dryrun: export GORELEASER_CURRENT_TAG := $(VERSION_TAG)
Expand Down