Addrgen encodings implementation + operands #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P-E-P
approved these changes
Oct 14, 2025
pietraferreira
force-pushed
the
pf-addrgen
branch
from
199b914 to
042103b
Compare
CohenArthur
reviewed
Oct 16, 2025
| tt.rocc.addrgen_wr_reg x0, 1, 2, a1, x0 | ||
| tt.rocc.addrgen_rd_reg a0, 0, 1, x0, x0 | ||
| tt.rocc.addrgen_reset 1 | ||
| tt.rocc.addrgen_reset_counters 0, x0 |
There was a problem hiding this comment.
So here we use 0, x0 because rs1 is marked as used in the spec? even though we don't really pass any values to the instruction?
| Parameter | Type | Description |
|---|---|---|
| cmdbuf | uint64_t | Command buffer ID (0-based) |
Instruction Fields:
| Field | Bits | Value | Description |
|---|---|---|---|
| funct7 | 31-25 | 0x1A | Function code |
| rs2 | 24-20 | 0x00 | Unused (x0) |
| rs1 | 19-15 | 0x00 | Zero value |
| xs2 | 12 | 0 | rs2 not used |
| xs1 | 13 | 1 | rs1 used |
There was a problem hiding this comment.
Yes. Because it says "rs1 used" then I do set it as so, but put a zero value in for the test so it matches the spec. But I guess yes, it seems like we will always pass in a zero value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this set of instructions we implement a new
regandcmdbufoperands which are0..31and0|1(32bit) instead of0..63and0|1(64bit).