Add slerp_with_rest() static func to Animation class
#107423
Open
+37
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
blend_with_rest
branch
2 times, most recently
from
d82a2e5 to
5e16f6a
Compare
TokageItLab
force-pushed
the
blend_with_rest
branch
from
5e16f6a to
2f2a8ea
Compare
TokageItLab
force-pushed
the
blend_with_rest
branch
from
2f2a8ea to
b388e41
Compare
TokageItLab
moved this from Work in progress
to Ready for review
in Animation Team Issue Triage
|
For now, the only existing code where the notation changes is the LookAtModifier. Therefore, I think it's sufficient if there are no issues with its out-of-boundary crossing tests.
The capture shows the behavior after this PR, but there was no change before and after the PR. |
TokageItLab
force-pushed
the
blend_with_rest
branch
3 times, most recently
from
fa51129 to
e574882
Compare
TokageItLab
force-pushed
the
blend_with_rest
branch
3 times, most recently
from
28ed8df to
b54e30f
Compare
TokageItLab
force-pushed
the
blend_with_rest
branch
3 times, most recently
from
9aabaf0 to
9662663
Compare
13 tasks
TokageItLab
force-pushed
the
blend_with_rest
branch
from
9662663 to
893b76b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Math::blend_from_angle()andQuaternion.blend_from()to blend rotations from an initial axis #100845Context: #100845 (comment)
Instead of exposing it, keep it as an internal refactoring. Also, write more essential things about function names and comments.
We will conduct tests later to ensure that the calculations remain unchanged before and after this.