-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: go clean
fails with ENOTEMPTY (openbsd) causing gopls test flakes
#68087
Comments
Found new dashboard test flakes for:
2024-06-20 14:20 x_tools-gotip-openbsd-amd64 tools@99779e9a go@4f77a835 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
|
Sorry, but there were parse errors in the watch flakes script.
And the problems were:
See https://go.dev/wiki/Watchflakes for details. |
@matloob @samthanawalla @adonovan Any particular reason why only on openbsd we'd be seeing these cleanup failures? Was there any recent change to the go command on openbsd? I don't think much has changed in gopls with respect to the integration test cleanup. Not a super high priority, but curious. |
I don't recall any changes specifically to openbsd |
Found new dashboard test flakes for:
2024-06-24 03:50 x_tools-go1.23-openbsd-amd64 tools@47bd819e release-branch.go1.23@7dff7439 x/tools/gopls/internal/test/integration/modfile.TestGovimModReadonly/default (log)
2024-06-26 14:39 x_tools-go1.23-openbsd-amd64 tools@02912f74 release-branch.go1.23@7dff7439 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
2024-06-26 17:06 x_tools-go1.22-openbsd-amd64 tools@b297f5a4 release-branch.go1.22@ceaf26ec x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
|
Found new dashboard test flakes for:
2024-06-27 17:53 x_tools-gotip-openbsd-amd64 tools@5cc2d0b1 go@ea537cca x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/default/default (log)
|
Found new dashboard test flakes for:
2024-06-27 17:53 x_tools-go1.23-openbsd-ppc64 tools@5cc2d0b1 release-branch.go1.23@7dff7439 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/default/default (log)
|
Found new dashboard test flakes for:
2024-06-28 20:28 x_tools-go1.23-openbsd-amd64 tools@fcf54632 release-branch.go1.23@7dff7439 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
|
Found new dashboard test flakes for:
2024-07-07 19:31 x_tools-gotip-openbsd-amd64 tools@33be3ef8 go@6d89b38e x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
|
Found new dashboard test flakes for:
2024-07-16 16:13 x_tools-go1.22-openbsd-amd64 tools@25ed04f2 release-branch.go1.22@9e148a41 x/tools/gopls/internal/test/integration/modfile.TestGovimModReadonly/default (log)
|
Found new dashboard test flakes for:
2024-07-19 17:32 x_tools-gotip-openbsd-amd64 tools@2fb3ebe9 go@f0de94ff x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
|
Found new dashboard test flakes for:
2024-08-01 00:23 x_tools-gotip-openbsd-amd64 tools@f6a23905 go@6ac87aa5 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/default/default (log)
|
Found new dashboard test flakes for:
2024-08-06 13:34 x_tools-go1.21-openbsd-amd64 tools@4653e48e release-branch.go1.21@8bba868d x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/default/default (log)
|
Found new dashboard test flakes for:
2024-08-08 21:40 x_tools-gotip-openbsd-amd64 tools@28ba9914 go@a01820c7 x/tools/gopls/internal/test/integration/modfile.TestGovimModReadonly/default (log)
|
Found new dashboard test flakes for:
2024-08-30 17:46 x_tools-go1.22-openbsd-amd64 tools@28f3bc0b release-branch.go1.22@e87be983 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/default/default (log)
|
Found new dashboard test flakes for:
2024-09-09 18:20 x_tools-go1.23-openbsd-amd64 tools@c055e89c release-branch.go1.23@e6598e7b x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/default/default (log)
|
Found new dashboard test flakes for:
2024-09-12 14:40 x_tools-gotip-openbsd-amd64 tools@15b8886a go@8efb5ebf x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/default/default (log)
2024-09-12 17:34 x_tools-gotip-openbsd-amd64 tools@beed481f go@8efb5ebf x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/default/default (log)
|
Found new dashboard test flakes for:
2025-02-18 14:38 x_tools-go1.23-openbsd-amd64 tools@94db7107 release-branch.go1.23@a991f9c3 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
|
Found new dashboard test flakes for:
2025-02-18 21:09 x_tools-go1.23-openbsd-amd64 tools@4b3fdfd8 release-branch.go1.23@a991f9c3 x/tools/gopls/internal/test/integration/modfile.TestGovimModReadonly/default (log)
|
Found new dashboard test flakes for:
2025-02-19 20:50 x_tools-go1.24-openbsd-amd64 tools@107c5b25 release-branch.go1.24@0f7b7600 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/default/default (log)
|
Found new dashboard test flakes for:
2025-02-20 21:23 x_tools-go1.23-openbsd-amd64 tools@9f7a2b61 release-branch.go1.23@22fdd35c x/tools/gopls/internal/test/integration/modfile.TestGovimModReadonly/default (log)
|
Found new dashboard test flakes for:
2025-02-21 15:23 x_tools-gotip-openbsd-amd64 tools@f95771e6 go@64d82cd7 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/nested/default (log)
|
Found new dashboard test flakes for:
2025-02-21 15:31 x_tools-go1.23-openbsd-amd64 tools@8b85edcc release-branch.go1.23@22fdd35c x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/default/default (log)
2025-02-21 18:18 x_tools-go1.24-openbsd-amd64 tools@23211ff4 release-branch.go1.24@0f7b7600 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
|
Found new dashboard test flakes for:
2025-02-21 18:51 x_tools-go1.23-openbsd-amd64 tools@7347766e release-branch.go1.23@22fdd35c x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/nested/default (log)
|
Found new dashboard test flakes for:
2025-02-21 21:16 x_tools-gotip-openbsd-amd64 tools@6e3d8bca go@f24b299d x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
2025-02-21 22:37 x_tools-gotip-openbsd-amd64 tools@5299dcb7 go@f24b299d x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/nested/default (log)
|
Found new dashboard test flakes for:
2025-02-24 14:40 x_tools-gotip-openbsd-amd64 tools@2b2a44ed go@fba83cdf x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/nested/default (log)
|
Found new dashboard test flakes for:
2025-02-24 17:21 x_tools-gotip-openbsd-amd64 tools@3e76cae7 go@dceee2e9 x/tools/gopls/internal/test/integration/codelens.TestUnusedDependenciesCodelens/default (log)
|
Found new dashboard test flakes for:
2025-02-25 21:13 x_tools-go1.24-openbsd-amd64 tools@6f7906b2 release-branch.go1.24@af236716 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
2025-02-25 21:13 x_tools-gotip-openbsd-amd64 tools@6f7906b2 go@b38b0c00 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
2025-02-25 21:57 x_tools-go1.24-openbsd-amd64 tools@7fed2a4a release-branch.go1.24@af236716 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/default/default (log)
|
Found new dashboard test flakes for:
2025-02-25 22:05 x_tools-gotip-openbsd-amd64 tools@6399d212 go@767c0fb9 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/nested/default (log)
|
Found new dashboard test flakes for:
2025-02-26 14:50 x_tools-go1.24-openbsd-amd64 tools@779331ac release-branch.go1.24@f5c38831 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
|
Found new dashboard test flakes for:
2025-02-27 21:21 x_tools-go1.23-openbsd-amd64 tools@1cc80ad5 release-branch.go1.23@e4772831 x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/default/default (log)
|
Found new dashboard test flakes for:
2025-02-28 20:28 x_tools-go1.24-openbsd-amd64 tools@5f02a3e8 release-branch.go1.24@5d692084 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_transitive_dependencies/default (log)
|
Found new dashboard test flakes for:
2025-03-03 14:37 x_tools-gotip-openbsd-amd64 tools@0efa5e51 go@0312e31e x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/default/default (log)
|
Found new dashboard test flakes for:
2025-03-03 20:07 x_tools-go1.23-openbsd-amd64 tools@2b1f5503 release-branch.go1.23@e4772831 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
|
Found new dashboard test flakes for:
2025-03-04 19:48 x_tools-go1.23-openbsd-amd64 tools@d81d6fcc release-branch.go1.23@45aade7f x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/nested/default (log)
|
Found new dashboard test flakes for:
2025-03-04 21:25 x_tools-gotip-openbsd-amd64 tools@8d38122b go@6f90ae36 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
|
Found new dashboard test flakes for:
2025-03-05 18:38 x_tools-go1.23-openbsd-amd64 tools@db6008cb release-branch.go1.23@45aade7f x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/default/default (log)
2025-03-05 19:59 x_tools-go1.23-openbsd-amd64 tools@25a90bef release-branch.go1.23@45aade7f x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
|
Found new dashboard test flakes for:
2025-03-06 18:34 x_tools-go1.24-openbsd-amd64 tools@b08c7a26 release-branch.go1.24@0ace2d8a x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/nested/default (log)
2025-03-07 21:08 x_tools-go1.23-openbsd-amd64 tools@29f81e9d release-branch.go1.23@45aade7f x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/default/default (log)
2025-03-07 21:08 x_tools-go1.24-openbsd-amd64 tools@29f81e9d release-branch.go1.24@0ace2d8a x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/default/default (log)
|
Found new dashboard test flakes for:
2025-03-08 17:41 x_tools-gotip-openbsd-amd64 tools@8fa586e1 go@bc5f4a55 x/tools/gopls/internal/test/integration/modfile.TestSumUpdateFixesDiagnostics/default (log)
|
This openbsd flake is a regular nuisance for the gopls CI build. The stderr output of
There are three places within os.RemoveAll that create an "unlinkat" error message:
It's hard to know why this might be a consistent problem on openbsd and not on other platforms. It would be a big help if we could add extra diagnostics to the go command so that in the case where the call to os.RemoveAll done by |
go clean
fails with ENOTEMPTY (openbsd) causing gopls test flakes
Found new dashboard test flakes for:
2025-03-12 17:21 x_tools-go1.23-openbsd-amd64 tools@4ee50fe6 release-branch.go1.23@45aade7f x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/default/default (log)
|
Found new dashboard test flakes for:
2025-03-14 01:02 x_tools-gotip-openbsd-amd64 tools@6c3e542d go@7dd7d70c x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/nested/default (log)
|
Change https://go.dev/cl/658816 mentions this issue: |
This change adds extra logging in the case where there's an error removing all the files in the gomodcache using modfetch.RemoveAll. It logs the names of the files found in GOMODCACHE as well as their modes. The modes are included because they should all be writable by the time we call robustio.RemoveAll. For #68087 Change-Id: Id9ae68bf6a3392baf88ec002d08fed1faf525927 Reviewed-on: https://go-review.googlesource.com/c/go/+/658816 Reviewed-by: Alan Donovan <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Michael Matloob <[email protected]>
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: