Skip to content

Adds the wait_until_at_setpoint() and wait_while_is_moving() methods available in StretchBody to wait for a joint to finish moving. #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025

Conversation

hello-robot-shehab
Copy link
Contributor

Resolves #46

@hello-robot-shehab hello-robot-shehab force-pushed the feature/wait-for-move-to-finish branch from 28d4f5f to b674e08 Compare April 26, 2025 02:52
@hello-robot-shehab hello-robot-shehab force-pushed the bug/move-commands-overriden branch from 786a10f to bd6d604 Compare May 9, 2025 22:16
@hello-robot-shehab hello-robot-shehab force-pushed the feature/wait-for-move-to-finish branch 2 times, most recently from 58b526d to 81c7910 Compare May 9, 2025 22:18
@hello-robot-shehab hello-robot-shehab force-pushed the feature/wait-for-move-to-finish branch from 1a9d62b to 83e9f15 Compare May 15, 2025 20:20
Base automatically changed from bug/move-commands-overriden to main May 15, 2025 21:10
@hello-robot-shehab hello-robot-shehab force-pushed the feature/wait-for-move-to-finish branch from 83e9f15 to 514f03d Compare May 15, 2025 21:30
@hello-robot-shehab hello-robot-shehab force-pushed the feature/wait-for-move-to-finish branch from 33fc48f to f16f72f Compare May 28, 2025 01:53
Copy link
Contributor

@hello-binit hello-binit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hello-robot-shehab hello-robot-shehab force-pushed the feature/wait-for-move-to-finish branch from 0f4f9d1 to f16f72f Compare May 28, 2025 02:06
… erratic motion when subsequent commands were sent. (#64)

* Added a BaseController than uses the physics callback to update the base motion

* The keyboard teleop example now stops the motion when the base control keys are released
This commit is a manual commit after the merge and rebase of 33fc48f
@hello-robot-shehab hello-robot-shehab merged commit 89aa7e4 into main May 28, 2025
1 check passed
@hello-robot-shehab hello-robot-shehab deleted the feature/wait-for-move-to-finish branch May 28, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move_by should give feedback on whether the requested position is reached (or thought to be reached).
2 participants