Fixed base velocity commands overriding each other, which was causing erratic motion when subsequent commands were sent. #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello-robot-shehab
changed the base branch from
main
to
feature/wait-for-move-to-finish
hello-robot-shehab
force-pushed
the
bugfix/base-better-motion
branch
from
c9f907c to
b3b9d8f
Compare
hello-robot-shehab
force-pushed
the
feature/wait-for-move-to-finish
branch
from
1a9d62b to
83e9f15
Compare
hello-robot-shehab
force-pushed
the
bugfix/base-better-motion
branch
from
b3b9d8f to
1d43259
Compare
hello-robot-shehab
force-pushed
the
feature/wait-for-move-to-finish
branch
from
83e9f15 to
514f03d
Compare
hello-robot-shehab
force-pushed
the
bugfix/base-better-motion
branch
from
6db90c5 to
bb1361c
Compare
hello-robot-shehab
changed the title
hello-robot-shehab
merged commit 33fc48f
into
feature/wait-for-move-to-finish
1 check passed
hello-robot-shehab
added a commit
that referenced
this pull request
May 28, 2025
… erratic motion when subsequent commands were sent. (#64) * Added a BaseController than uses the physics callback to update the base motion * The keyboard teleop example now stops the motion when the base control keys are released This commit is a manual commit after the merge and rebase of 33fc48f
hello-robot-shehab
added a commit
that referenced
this pull request
May 28, 2025
… erratic motion when subsequent commands were sent. (#64) * Added a BaseController than uses the physics callback to update the base motion * The keyboard teleop example now stops the motion when the base control keys are released This commit is a manual commit after the merge and rebase of 33fc48f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #63
Bug: Notice that the speed of the base is slow while the W key is held at the beginning, then it jumps when the key is released. This is not the expected behavior:
base-bad-motion.webm.mp4
Fix: The motion is smooth while the key is held down:
base-better-motion-fix.webm.mp4