[CI] Fix race condition by unsetting merge_ref for Windows tasks
#16757
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That input parameter was introduced to `sycl-windows-build.yml` in intel#16560 but it's unclear why. Note that linux version has had it for quite some time, but we started unsetting it explicitly in intel#10720. The reason we had it for Linux in the first place is because `GITHUB_SHA` pointed to the PR's source branch for the `pull_request_target` trigger that we used at that time. With switching to `pull_request` trigger it became unnecessary as `GITHUB_SHA` points to the merge commit already. This change should fix current race condition when a post-commit CI job can test change landed after the current commit if there is a delay with runner allocation.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
approved these changes
Jan 23, 2025
IMO, we should remove or switch the default, but I'd like to hear from @KornevNikita about his use-case first. In the meanwhile, fixing the CI can't wait :) |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That input parameter was introduced to
sycl-windows-build.ymlin #16560 but it's unclear why.Note that linux version has had it for quite some time, but we started unsetting it explicitly in #10720. The reason we had it for Linux in the first place is because
GITHUB_SHApointed to the PR's source branch for thepull_request_targettrigger that we used at that time. With switching topull_requesttrigger it became unnecessary asGITHUB_SHApoints to the merge commit already.This change should fix current race condition when a post-commit CI job can test change landed after the current commit if there is a delay with runner allocation.