[ADD] Estate: create a new module for real estate management #786

josv-odoo · 2025-05-19T15:05:10Z

Creation of module estate
Create Access file
Create Model for module

robodoo · 2025-05-19T15:05:13Z

barracudapps · 2025-05-20T02:48:25Z

@josv-odoo
Can you please review the name of your PR and your commits titles/messaged ?
Everything you need to know is here

barracudapps

Hi @josv-odoo
Here are small improvements you can apply to your codebase to match development standards at Odoo
👍

barracudapps · 2025-05-20T02:49:25Z

estate/__manifest__.py

@@ -0,0 +1,14 @@
+{
+    'name': "Real estate",


Suggested change

'name': "Real estate",

'name': 'Real estate',

Prefer using double quotes ("") for long strings, multiline or user inputs/displays.

barracudapps · 2025-05-20T02:50:12Z

estate/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1


Suggested change

access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1

access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1

Always newline character at the end of your files for UNIX compatibility.

barracudapps · 2025-05-20T02:50:28Z

estate/view/estate_property_views.xml

+    <field name="name">Test action</field>
+    <field name="res_model">test_model</field>
+    <field name="view_mode">list,form</field>
+</record>


Suggested change

</record>

</record>

Same here.

barracudapps

@josv-odoo
Please, don't push local config files (pyproject.toml) as they are not part of the project.
Small changes required.
👍

barracudapps · 2025-05-20T10:20:56Z

estate/models/estate_property.py

+from odoo import fields, models
+
+
+class TestModel(models.Model):


Rename your model accordingly based on the module
Some interesting docs:

https://www.odoo.com/documentation/18.0/contributing/development/coding_guidelines.html?highlight=naming#symbols-and-conventions

https://peps.python.org/pep-0008/#naming-conventions

barracudapps · 2025-05-20T10:24:24Z

estate/models/estate_property.py

+    _description = 'It allows to manage your properties'
+    name = fields.Char(required=True, default='Unknown')


Suggested change

_description = 'It allows to manage your properties'

name = fields.Char(required=True, default='Unknown')

_description = 'It allows to manage your properties'

name = fields.Char(required=True, default='Unknown')

There should be an empty space here to distinguish private attributes from fields

barracudapps · 2025-05-21T08:08:45Z

@josv-odoo ,
Please keep this in mind:

@josv-odoo Can you please review the name of your PR and your commits titles/messaged ?
Everything you need to know is here

The title is nearly correct, one small change required though

barracudapps · 2025-05-21T08:09:39Z

estate/.gitignore

+#Untracked files
+pyproject.toml


Please don't push your local configuration

Don't forget this one please

barracudapps · 2025-05-21T08:11:26Z

estate/view/estate_property_views.xml

+        <field name="arch" type="xml">
+            <search string="Search Estates">
+                <field name="name"/>
+                <filter string="Available" name="available" domain="[('state', '!=', 'sold' ), ('state', '!=', 'cancelled'), ('state', '!=', 'offer_accepted')]"/>


Try using not in

…ate_property_? offer, tag and type\n create one2many, many2one and many2many fields

… Improve the aesthetics. . Security: prohibit: duplicate tags and negative prices Actions: added visuals for properties state, linked status of offer to state of properties, added action to accept/refuse offer, added action to sold/cancel properties. Aesthetics : Added color to tags, hidden sold/cancelled/accepted/refused button (properties view), added status as a status bar on top (properties view), added properties (in properties type view)

barracudapps · 2025-05-22T23:34:34Z

estate/.gitignore

+#Untracked files
+pyproject.toml


Don't forget this one please

barracudapps · 2025-05-22T23:36:13Z

estate/models/estate_property_offer.py

+            if record.create_date:
+                record.date_deadline = record.create_date + relativedelta(days=record.validity)
+            else:
+                record.date_deadline = fields.Date.today() + relativedelta(days=record.validity)


Probably a better way to do using or

barracudapps · 2025-05-22T23:37:35Z

estate/models/estate_property.py

+    def action_property_sold(self):
+        for record in self:
+            if record.state == 'cancelled':
+                raise exceptions.UserError('property already cancelled')


Import your exceptions for an easier future use

barracudapps · 2025-05-22T23:38:47Z

estate/models/estate_property.py

+    def action_property_cancelled(self):
+        for record in self:
+            if record.state == 'sold':
+                raise exceptions.UserError('property already sold')


Suggested change

raise exceptions.UserError('property already sold')

raise UserError(self.env._('property already sold'))

As Séna would say:

In Odoo, translatable strings in "data"-type content are automatically exported for translation. However, other user-facing strings, Odoo cannot automatically know whether they are translatable. To ensure these strings are exported for translation, you need to explicitly mark them. This is achieved by wrapping the literal string with the self.env._() function. The _() function signals to Odoo's translation system that the string should be included in the translation catalog.

More info here: https://www.odoo.com/documentation/18.0/developer/howtos/translations.html#explicit-exports

You can check this line here:
https://github.com/odoo/odoo/blob/05cff3b7d866f6bc95c4b32f343ae14a4da946f2/addons/account/models/account_move.py#L2075

…removed gitignore

…ype. -Added smart button on property type form view. -Added a variable to estate.property.offer and estate.property.type -Added a field offer_count to improve readability of the smart button (number of offers availables)

Kanban: - new kanban record in the xml and add kanban as standard view Link with invoicing: New module called estate_account - model called estate_sold_inherited that inherit from account to implement on "action_property_sold" (when a property is marked as sold) to create an invoice with the following lines: * property price * commission for the sale of property * Administrative fees

- move estate.estate_property_type_offer_action - checkStyle: super(class,self) -> super() - erase '_' at the end of compute function

barracudapps suggested changes May 20, 2025

View reviewed changes

josv-odoo force-pushed the 18.0-task-tutorial-josv branch from 5158389 to 6596273 Compare May 20, 2025 08:40

josv-odoo changed the title ~~commit end first day chapter 4 ended~~ [ADD] base: create a new module for real estate management May 20, 2025

josv-odoo force-pushed the 18.0-task-tutorial-josv branch from 6596273 to e9d5840 Compare May 20, 2025 09:39

barracudapps suggested changes May 20, 2025

View reviewed changes

josv-odoo force-pushed the 18.0-task-tutorial-josv branch from e3e2293 to c55f8e7 Compare May 20, 2025 11:20

[ADD] base: create a new module for real estate management

cdc392e

josv-odoo force-pushed the 18.0-task-tutorial-josv branch from 0ce39ff to cdc392e Compare May 20, 2025 11:30

josv-odoo changed the title ~~[ADD] base: create a new module for real estate management~~ [ADD] Estate: create a new module for real estate management May 20, 2025

[IMP] Estate: add the property types

b6990b9

barracudapps suggested changes May 21, 2025

View reviewed changes

josv-odoo added 2 commits May 21, 2025 13:11

[IMP] Estate: Improve relation between model\n create new models: est…

c5e1685

…ate_property_? offer, tag and type\n create one2many, many2one and many2many fields

josv-odoo force-pushed the 18.0-task-tutorial-josv branch from 6efe63a to bc6fa2c Compare May 22, 2025 14:33

barracudapps reviewed May 22, 2025

View reviewed changes

josv-odoo added 4 commits May 23, 2025 09:45

[FIX] Estate: apply fix on ErrorExceptions, record.date_deadline and …

32ac36a

…removed gitignore

[FIX] Estate: relocate action before it's call.

07bdb3c

- move estate.estate_property_type_offer_action - checkStyle: super(class,self) -> super() - erase '_' at the end of compute function

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
		access_estate_property,access_estate_property,model_estate_property,base.group_user,1,1,1,1

		from odoo import fields, models


		class TestModel(models.Model):

		_description = 'It allows to manage your properties'
		name = fields.Char(required=True, default='Unknown')

	raise exceptions.UserError('property already sold')
	raise UserError(self.env._('property already sold'))

		#Untracked files
		pyproject.toml

		#Untracked files
		pyproject.toml

[ADD] Estate: create a new module for real estate management #786

Are you sure you want to change the base?

[ADD] Estate: create a new module for real estate management #786

Uh oh!

Conversation

josv-odoo commented May 19, 2025

Uh oh!

robodoo commented May 19, 2025

Uh oh!

barracudapps commented May 20, 2025

Uh oh!

barracudapps left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barracudapps left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

barracudapps commented May 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!