Fix all fixable stubtest_allowlist entries in SQLAlchemy #9596

Avasam · 2023-01-27T02:48:08Z

This PR focuses solely on fixing as many stubtest_allowlist entries as possible (unless they're caused by an issue with subtest itself).
Also regrouped and reorganized some entries while updating comments.

stubs/SQLAlchemy/sqlalchemy/orm/strategy_options.pyi

AlexWaygood

Thank you! Overall this looks great, just a few comments below:

stubs/SQLAlchemy/sqlalchemy/orm/collections.pyi

stubs/SQLAlchemy/sqlalchemy/orm/strategy_options.pyi

AlexWaygood · 2023-01-28T12:13:06Z

stubs/SQLAlchemy/sqlalchemy/orm/strategy_options.pyi

+class loader_option(Generic[_F]):
+    name: str
+    _dynamic: _F
+    fn: _F
+    __call__: _F  # Cheesy "__call__" definition to use the dynamic methods instead


Would you be able to add a couple of test cases for this, so we can be sure the type hints are working correctly?

I think the recent changes are much simpler and probably won't require test cases. I'll let you decide.

I'd still prefer one or two test cases, if that's okay :)

(tests added in a previous commit)

stubs/SQLAlchemy/sqlalchemy/testing/provision.pyi

AlexWaygood · 2023-01-28T12:19:51Z

stubs/SQLAlchemy/sqlalchemy/testing/provision.pyi

+class register(Generic[_F]):
+    fns: dict[str, _F]
+    @classmethod
+    def init(cls: type[Self], fn: _F) -> Self: ...
+    def for_db(self: Self, *dbnames: str) -> Callable[[_F], Self]: ...
+    __call__: _F


Same here -- maybe add a test case or two?

It looks like the tests I can do for register are really limited. For example, because it's generic, I get [assert-type] errors like:
Expression is of type "register[Callable[[object, object, object], None]]", not "register[Any]", or
Expression is of type "register[Callable[[object, object, object], None]]", not "register[Callable[[object, object, object], None]]"

At least I can test that the first parameter is correctly replaced.

https://github.com/python/typeshed/actions/runs/4045446150/jobs/6956947952

(tests added in a previous commit)

stubs/SQLAlchemy/sqlalchemy/util/compat.pyi

stubs/SQLAlchemy/@tests/stubtest_allowlist.txt

hauntsaninja · 2023-01-28T16:13:05Z

(not a review, but those line diff counts look great!!)

Avasam · 2023-01-29T03:25:08Z

(not a review, but those line diff counts look great!!)

One of the few times we like seeing a lot of red ^^

I've yet to add some tests. But that's all the time I had right now. Will tackle those later.

…hemy-stubtest

into sqlalchemy-stubtest

Avasam · 2023-01-30T16:34:26Z

~~#9622~~ #9650 concerning "Check file consistency"

JelleZijlstra · 2023-03-09T06:00:12Z

stubs/SQLAlchemy/@tests/test_cases/check_register.py

+    pass
+
+
+no_args(cfg="")


Is it useful to assert_type the return type of these and the next functions?

Idk if it's useful because of:
https://github.com/python/typeshed/pull/9596/files#diff-548edbccead15d5b517e8f12d71ae94f90c0e5a7dbdb8eea1657139fe8d74a92R31-R32

# Impossible to specify the args from the generic Callable in the current type system def __call__(self, cfg: str | URL | _ConfigProtocol, *arg: Any) -> str | URL | None: ... # AnyOf[str | URL | None]

In theory the return type should be infered from the undecorated function (which would be worth testing). But we're unable to (or at least I was at the moment of writing this stub).

stubs/SQLAlchemy/sqlalchemy/engine/url.pyi

Avasam · 2023-03-16T15:44:34Z

(I've been quite occupied last week, and I got sick this week, will go through updated reviews soon once I feel a bit better)

into sqlalchemy-stubtest

…hemy-stubtest

Avasam · 2023-03-31T19:27:49Z

@AlexWaygood @JelleZijlstra Can I get an updated review on this? I answered the comments and I don't think there was anything new to add (just merged main to resolve conflicts)

github-actions · 2023-03-31T19:29:49Z

Diff from mypy_primer, showing the effect of this PR on open source code:

prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/server/schemas/sorting.py:38: error: "coalesce" has no attribute "asc"  [attr-defined]
- src/prefect/server/schemas/sorting.py:41: error: "coalesce" has no attribute "desc"  [attr-defined]

stubs/SQLAlchemy/sqlalchemy/util/langhelpers.pyi

Co-authored-by: Jelle Zijlstra <[email protected]>

JelleZijlstra · 2023-04-14T22:18:48Z

@AlexWaygood let's merge this?

stubs/SQLAlchemy/sqlalchemy/util/langhelpers.pyi

AlexWaygood · 2023-04-14T22:23:14Z

@AlexWaygood let's merge this?

I remember having some qualms a while back about a few minor things that I wanted to investigate further, but I can't remember what they are anymore, and I don't think they really matter in the scheme of things :)

Let's go for it.

AlexWaygood · 2023-04-14T22:26:27Z

@Avasam sorry for the delay on this one 😔

Avasam · 2023-04-15T00:28:00Z

I remember having some qualms a while back about a few minor things that I wanted to investigate further, but I can't remember what they are anymore, and I don't think they really matter in the scheme of things :)

There's a follow-up PR anyway (which may or may not have conflicts now, I haven't checked). If you remember anything you can mention it there too.

Avasam · 2023-04-29T17:03:25Z

Just leaving a comment here to link to #9127 (comment)

Fix most stubtest_allowlist entries in SQLAlchemy

c1545b7

Avasam commented Jan 27, 2023

View reviewed changes

stubs/SQLAlchemy/sqlalchemy/orm/strategy_options.pyi Outdated Show resolved Hide resolved

Import typo

0c2003b

This comment has been minimized.

Sign in to view

Avasam changed the title ~~Fix most stubtest_allowlist entries in SQLAlchemy~~ Fix all fixable stubtest_allowlist entries in SQLAlchemy Jan 27, 2023

Avasam mentioned this pull request Jan 28, 2023

Combine microsoft/python-type-stubs/sqlalchemy #9597

Closed

AlexWaygood reviewed Jan 28, 2023

View reviewed changes

stubs/SQLAlchemy/@tests/stubtest_allowlist.txt Outdated Show resolved Hide resolved

AlexWaygood reviewed Jan 28, 2023

View reviewed changes

stubs/SQLAlchemy/@tests/stubtest_allowlist.txt Show resolved Hide resolved

Avasam and others added 2 commits January 28, 2023 22:21

Address some PR comments

50190e1

[pre-commit.ci] auto fixes from pre-commit.com hooks

125c2dd

This comment has been minimized.

Sign in to view

Avasam added 2 commits January 30, 2023 05:06

Merge branch 'main' of https://github.com/python/typeshed into sqlalc…

8d659c0

…hemy-stubtest

Simplified loader_option and register

9d9647f

Avasam requested a review from AlexWaygood January 30, 2023 12:11

This comment has been minimized.

Sign in to view

Avasam mentioned this pull request Jan 30, 2023

stubtest: False-positives with parameter name mangling outside of classes python/mypy#14560

Closed

Avasam and others added 5 commits January 30, 2023 10:30

Tests with showing limitaitons

597d925

[pre-commit.ci] auto fixes from pre-commit.com hooks

6a5ca2c

Remove test limitation demo

5d35846

Merge branch 'sqlalchemy-stubtest' of https://github.com/Avasam/typeshed

edc7bf0

into sqlalchemy-stubtest

Ensure modern syntax

36952cd

This comment has been minimized.

Sign in to view

fix pyrigth test_cases

952f8a7

Even better first arg check

724e248

This comment has been minimized.

Sign in to view

Avasam mentioned this pull request Feb 1, 2023

Mark SQLAlchemy stubs with ignore_missing_stub = false #9653

Merged

JelleZijlstra reviewed Mar 9, 2023

View reviewed changes

Merge branch 'main' into sqlalchemy-stubtest

2ed6302

This comment has been minimized.

Sign in to view

AlexWaygood reviewed Mar 16, 2023

View reviewed changes

stubs/SQLAlchemy/sqlalchemy/engine/url.pyi Outdated Show resolved Hide resolved

Update stubs/SQLAlchemy/sqlalchemy/engine/url.pyi

e96e15c

This comment has been minimized.

Sign in to view

Merge branch 'main' into sqlalchemy-stubtest

dd69c48

Avasam requested review from JelleZijlstra and AlexWaygood and removed request for JelleZijlstra March 22, 2023 17:11

Avasam added 2 commits March 22, 2023 13:13

Update usage of Self

6e7f6cc

Merge branch 'sqlalchemy-stubtest' of https://github.com/Avasam/typeshed

c3f7651

into sqlalchemy-stubtest

This comment has been minimized.

Sign in to view

Avasam added 2 commits March 31, 2023 15:17

Ran stubdefaulter before merge

e266ef7

Merge branch 'main' of https://github.com/python/typeshed into sqlalc…

fac6a60

…hemy-stubtest

JelleZijlstra self-requested a review March 31, 2023 19:41

JelleZijlstra approved these changes Apr 14, 2023

View reviewed changes

stubs/SQLAlchemy/sqlalchemy/util/langhelpers.pyi Outdated Show resolved Hide resolved

stubs/SQLAlchemy/sqlalchemy/util/langhelpers.pyi Outdated Show resolved Hide resolved

Apply suggestions from code review

55b20ed

Co-authored-by: Jelle Zijlstra <[email protected]>

AlexWaygood reviewed Apr 14, 2023

View reviewed changes

stubs/SQLAlchemy/sqlalchemy/util/langhelpers.pyi Outdated Show resolved Hide resolved

'Nother typo

f182bbb

JelleZijlstra merged commit b0ed50e into python:main Apr 14, 2023

Avasam deleted the sqlalchemy-stubtest branch April 14, 2023 23:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix all fixable stubtest_allowlist entries in SQLAlchemy #9596

Fix all fixable stubtest_allowlist entries in SQLAlchemy #9596

Avasam commented Jan 27, 2023 •

edited

Loading

This comment has been minimized.

AlexWaygood left a comment

AlexWaygood Jan 28, 2023

Avasam Jan 30, 2023

AlexWaygood Jan 30, 2023

Avasam Mar 22, 2023

AlexWaygood Jan 28, 2023

Avasam Jan 30, 2023 •

edited

Loading

Avasam Mar 22, 2023

hauntsaninja commented Jan 28, 2023

Avasam commented Jan 29, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Avasam commented Jan 30, 2023 •

edited

Loading

This comment has been minimized.

JelleZijlstra Mar 9, 2023

Avasam Mar 22, 2023 •

edited

Loading

This comment has been minimized.

Avasam commented Mar 16, 2023

This comment has been minimized.

This comment has been minimized.

Avasam commented Mar 31, 2023

github-actions bot commented Mar 31, 2023

JelleZijlstra commented Apr 14, 2023

AlexWaygood commented Apr 14, 2023 •

edited

Loading

AlexWaygood commented Apr 14, 2023

Avasam commented Apr 15, 2023

Avasam commented Apr 29, 2023

		pass


		no_args(cfg="")

Fix all fixable stubtest_allowlist entries in SQLAlchemy #9596

Fix all fixable stubtest_allowlist entries in SQLAlchemy #9596

Conversation

Avasam commented Jan 27, 2023 • edited Loading

This comment has been minimized.

AlexWaygood left a comment

Choose a reason for hiding this comment

AlexWaygood Jan 28, 2023

Choose a reason for hiding this comment

Avasam Jan 30, 2023

Choose a reason for hiding this comment

AlexWaygood Jan 30, 2023

Choose a reason for hiding this comment

Avasam Mar 22, 2023

Choose a reason for hiding this comment

AlexWaygood Jan 28, 2023

Choose a reason for hiding this comment

Avasam Jan 30, 2023 • edited Loading

Choose a reason for hiding this comment

Avasam Mar 22, 2023

Choose a reason for hiding this comment

hauntsaninja commented Jan 28, 2023

Avasam commented Jan 29, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Avasam commented Jan 30, 2023 • edited Loading

This comment has been minimized.

JelleZijlstra Mar 9, 2023

Choose a reason for hiding this comment

Avasam Mar 22, 2023 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

Avasam commented Mar 16, 2023

This comment has been minimized.

This comment has been minimized.

Avasam commented Mar 31, 2023

github-actions bot commented Mar 31, 2023

JelleZijlstra commented Apr 14, 2023

AlexWaygood commented Apr 14, 2023 • edited Loading

AlexWaygood commented Apr 14, 2023

Avasam commented Apr 15, 2023

Avasam commented Apr 29, 2023

Avasam commented Jan 27, 2023 •

edited

Loading

Avasam Jan 30, 2023 •

edited

Loading

Avasam commented Jan 29, 2023 •

edited

Loading

Avasam commented Jan 30, 2023 •

edited

Loading

Avasam Mar 22, 2023 •

edited

Loading

AlexWaygood commented Apr 14, 2023 •

edited

Loading